BOOKKEEPER-962: Add more journal timing stats#70
Closed
merlimat wants to merge 1 commit into
Closed
Conversation
sijie
approved these changes
Nov 9, 2016
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
The change looks good to me. +1
kishorekasi
pushed a commit
to kishorekasi/bookkeeper
that referenced
this pull request
Jul 18, 2017
It is useful to know the sync latency on the journal to identify disk/filesystem related latency spikes that will cause all the entries to queue up. In the same line, it's useful to track the amount of time spent in the journal queue. Author: Matteo Merli <mmerli@yahoo-inc.com> Reviewers: Sijie Guo <sijie@apache.org> Closes apache#70 from merlimat/bk-journal-latency Conflicts: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
kishorekasi
pushed a commit
to kishorekasi/bookkeeper
that referenced
this pull request
Feb 14, 2018
…er settings configs. (apache#70)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is useful to know the sync latency on the journal to identify disk/filesystem
related latency spikes that will cause all the entries to queue up. In the same
line, it's useful to track the amount of time spent in the journal queue.