Skip to content

Fix Flaky CreateNewLogTest #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sijie wants to merge 1 commit into from
Closed

Fix Flaky CreateNewLogTest #836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CreateNewLogTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public void testCreateNewLog() throws Exception {
conf.setLedgerDirNames(ledgerDirs);
LedgerDirsManager ledgerDirsManager = new LedgerDirsManager(conf, conf.getLedgerDirs(),
new DiskChecker(conf.getDiskUsageThreshold(), conf.getDiskUsageWarnThreshold()));
EntryLogger el = new EntryLogger(conf, ledgerDirsManager);

// Extracted from createNewLog()
String logFileName = Long.toHexString(1) + ".log";
Expand All @@ -98,6 +97,7 @@ public void testCreateNewLog() throws Exception {
File newLogFile = new File(dir, logFileName);
newLogFile.createNewFile();

EntryLogger el = new EntryLogger(conf, ledgerDirsManager);
// Calls createNewLog, and with the number of directories we
// are using, if it picks one at random it will fail.
el.createNewLog();
Expand All @@ -114,7 +114,6 @@ public void testCreateNewLogWithNoWritableLedgerDirs() throws Exception {
conf.setIsForceGCAllowWhenNoSpace(true);
LedgerDirsManager ledgerDirsManager = new LedgerDirsManager(conf, conf.getLedgerDirs(),
new DiskChecker(conf.getDiskUsageThreshold(), conf.getDiskUsageWarnThreshold()));
EntryLogger el = new EntryLogger(conf, ledgerDirsManager);

// Extracted from createNewLog()
String logFileName = Long.toHexString(1) + ".log";
Expand All @@ -129,6 +128,7 @@ public void testCreateNewLogWithNoWritableLedgerDirs() throws Exception {
ledgerDirsManager.addToFilledDirs(tdir);
}

EntryLogger el = new EntryLogger(conf, ledgerDirsManager);
// Calls createNewLog, and with the number of directories we
// are using, if it picks one at random it will fail.
el.createNewLog();
Expand Down