Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to dep for br dependency management #72

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@geomacy
Copy link
Contributor

commented Nov 19, 2018

Switch to dep for dependency management. Have meant to do this for ages, thought it would be worthwhile before releasing 1.0.0.

It works for me™️, but would appreciate someone else pulling this to test it out.

Most of the changes are deletes of files in vendor, which dep did upon dep init. Evidently they are not needed.

@tbouron

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

Tested, works great! Thanks @geomacy it is much cleaner that way :)

@asfgit asfgit merged commit 868863a into apache:master Nov 20, 2018

1 check passed

Jenkins: brooklyn-client-pull-request SUCCESS 25 tests run, 0 skipped, 0 failed.
Details

asfgit pushed a commit that referenced this pull request Nov 20, 2018

@geomacy geomacy deleted the geomacy:dep branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.