From 22d9131dbc43158c19084457d26265ae42597765 Mon Sep 17 00:00:00 2001 From: Aled Sage Date: Sat, 28 May 2016 15:01:29 +0100 Subject: [PATCH] Minor tidy to LoopOverGroupMembersTestCase --- .../LoopOverGroupMembersTestCaseImpl.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java b/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java index f4bb06d67e..58dce17332 100644 --- a/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java +++ b/test-framework/src/main/java/org/apache/brooklyn/test/framework/LoopOverGroupMembersTestCaseImpl.java @@ -67,17 +67,21 @@ public void start(@EffectorParam(name = "locations") Collection children = group.getMembers(); + Collection members = group.getMembers(); boolean allSuccesful = true; - for (Entity child : children) { - testSpec.configure(TestCase.TARGET_ENTITY, child); + for (Entity member : members) { + EntitySpec testSpecCopy = EntitySpec.create(testSpec) + .configure(TestCase.TARGET_ENTITY, member); try { - TargetableTestComponent targetableTestComponent = this.addChild(testSpec); + TargetableTestComponent targetableTestComponent = this.addChild(testSpecCopy); targetableTestComponent.start(locations); + logger.debug("Task of {} successfully run, targetting {}", this, member); } catch (Throwable t) { + Exceptions.propagateIfFatal(t); + logger.warn("Problem in child test-case of "+this+", targetting "+member, t); allSuccesful = false; } }