VanillaSoftwareProcess tests #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledsage
force-pushed
the
VanillaSoftwareProcess-tests
branch
from
5cc274f
to
d24e0de
Compare
|
@aledsage not sure about |
|
It was something to do with entities setting object properties on |
|
LGTM |
|
@grkvlt any objections to me merging this? I'll do so later today, unless you say otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For " Don’t call postInstallCommand if skipInstall=true", why did we previous still call postInstall @grkvlt ?
The bulk of this PR is the unit testing of VanillaSoftwareProcess, using the
RecordSshToolto stub out all the ssh commands.Note the "Adds EffectorUtilsTest" is unrelated - I meant to include it in a PR a while ago, but accidentally missed it! We previously didn't have any tests that covered these methods directly.