Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use checkboxes for blueprint type in save modal #107

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@grkvlt
Copy link
Member

commented Nov 9, 2018

Updates the advanced section of the save to catalog modal dialog to use checkboxes instead, with more helpful text labels

Use checkboxes for blueprint type in save modal
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>
@ahgittin

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2018

a few comments. pretty straightforward but the checkboxes semantics don't seem right.

item: blueprint
};

// Set the itemType to the correct value or leave out entirely if config undefined
let itemType = $scope.config.entity ? 'entity' : $scope.config.template ? 'template' : undefined;

This comment has been minimized.

Copy link
@ahgittin

ahgittin Nov 12, 2018

Contributor

this logic is not what the use of checkboxes implies. also, if nothing is selected undefined will generate invalild catalog BOM, no?

suggest leaving it as radiobuttons with a variable $scope.config.itemType defaulting to `template ?

<div class="checkbox">
<label>
<input ng-model="config.template" ng-disabled="state.saving" name="template" type="checkbox" ng-change="config.template && (config.entity = !config.template)" />
Save this as a template displayable in quick-launch

This comment has been minimized.

Copy link
@ahgittin

ahgittin Nov 12, 2018

Contributor

could text be: Save as "template" which can be used as an editable starting point for other blueprints or quick-launched directly if that is too long we could simply show Template (i) with help popup showing the longer text.

<div class="checkbox">
<label>
<input ng-model="config.entity" ng-disabled="state.saving" name="entity" type="checkbox" ng-change="config.entity && (config.template = !config.entity)" />
Store this blueprint as an extension to the referenced entities

This comment has been minimized.

Copy link
@ahgittin

ahgittin Nov 12, 2018

Contributor

as above, better longer text here might be Save as a new "entity" type which can be used in blueprints

Change to radio buttons with help text
Signed-off-by: Andrew Donald Kennedy <andrew.kennedy@cloudsoftcorp.com>

@asfgit asfgit merged commit 0804c5c into apache:master Nov 13, 2018

1 check passed

Jenkins: brooklyn-ui-pull-request SUCCESS 10 tests run, 0 skipped, 0 failed.
Details

asfgit pushed a commit that referenced this pull request Nov 13, 2018

asfgit pushed a commit that referenced this pull request Nov 13, 2018

@ahgittin

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2018

LGTM. There was one extra blank line change which I've undone (as it conflicted with #108), and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.