Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback for customising yaml loading #95

Merged
merged 1 commit into from Nov 2, 2018

Conversation

sferot
Copy link
Contributor

@sferot sferot commented Oct 31, 2018

No description provided.

@ahgittin
Copy link
Contributor

ahgittin commented Nov 2, 2018

good refactor @sferot . i note you have an ICLA so this is good to go.

heads up, @tbouron has been spiking angularjs decorators which should provide an easier pattern to override/customize. if you are wanting to override this you could try that and let us know how it goes!

merging

@asfgit asfgit merged commit c4367b2 into apache:master Nov 2, 2018
asfgit pushed a commit that referenced this pull request Nov 2, 2018
@ahgittin
Copy link
Contributor

ahgittin commented Nov 2, 2018

actually this is giving errors when i run it:

TypeError: this.$q.defer is not a function
    at BlueprintLoaderApiProvider.loadBlueprint (blueprint-loader-api.provider.js:51)

will try to fix but if i can't i'll have to revert

asfgit pushed a commit that referenced this pull request Nov 2, 2018
@ahgittin
Copy link
Contributor

ahgittin commented Nov 2, 2018

@sferot fix pushed, but pls check it's what you intended

65d3740

@LudoPL
Copy link
Contributor

LudoPL commented Nov 5, 2018

Thanks @ahgittin for the merge and the fix
@sferot is in holidays since last wednesday, he will come back on the 12th.
If I have the time week I may try to look at it (but not sure).

sferot pushed a commit to usharesoft/brooklyn-ui that referenced this pull request Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants