From fd169a7bea1c9ac9b35f9e9f6cdc4a7b6f9a15d3 Mon Sep 17 00:00:00 2001 From: Thomas Bouron Date: Wed, 7 Nov 2018 09:39:34 +0000 Subject: [PATCH 1/2] Apply naming convention for templates used with $templateCache This is using the following: /(component|view)//.html --- .../catalog-selector.directive.js | 8 ++----- .../catalog-selector.template.html | 4 ++-- .../spec-editor/spec-editor.template.html | 24 +++++++++---------- 3 files changed, 16 insertions(+), 20 deletions(-) diff --git a/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js b/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js index b8b3bc608..9e8774bdc 100644 --- a/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js +++ b/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js @@ -411,12 +411,8 @@ function controller($scope, $element, $timeout, $q, $uibModal, $log, $templateCa // it is used by catalogSelectorFiltersFilter; $scope.filterPaletteItemsForMode = (items) => items; - // downstream can override this to insert lines below the header - $scope.customSubHeadTemplateName = 'composer-palette-empty-sub-head'; - $templateCache.put($scope.customSubHeadTemplateName, ''); - - $scope.customFooterTemplateName = 'composer-palette-default-footer'; - $templateCache.put($scope.customFooterTemplateName, footerTemplate); + $templateCache.put('blueprint-composer/component/catalog-selector/subhead.html', ''); + $templateCache.put('blueprint-composer/component/catalog-selector/footer.html', footerTemplate); // allow downstream to configure this controller and/or scope (composerOverrides.configurePaletteController || function() {})(this, $scope, $element); diff --git a/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html b/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html index 3b6eaa3fc..5b4ddb9d2 100644 --- a/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html +++ b/ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html @@ -92,7 +92,7 @@ - + @@ -146,7 +146,7 @@

{{freeFormTile | entityName}}

diff --git a/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html b/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html index 937bbaa7f..8dec82b55 100644 --- a/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html +++ b/ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html @@ -309,7 +309,7 @@

No matching configuration

class="open-entity-spec" title="Open in spec editor" ng-focus="specEditor.recordFocus(item)"> - + (no spec set) @@ -341,8 +341,8 @@

No matching configuration

- - - - - - - - @@ -494,7 +494,7 @@

No enrichers -