Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build was failed due to |
wwbmmm
requested changes
Mar 28, 2022
wwbmmm
reviewed
Mar 29, 2022
|
LGTM |
wwbmmm
reviewed
Mar 30, 2022
wwbmmm
approved these changes
Mar 30, 2022
wasphin
reviewed
Mar 30, 2022
| // use template to avoid include `google/protobuf/message.h` | ||
| template<typename T> | ||
| inline uint32_t GetProtobufByteSize(const T& message) { | ||
| #if GOOGLE_PROTOBUF_VERSION >= 3010000 |
There was a problem hiding this comment.
在不包含 protobuf 相关头文件的情况下, 直接用 GOOGLE_PROTOBUF_VERSION 有问题吧? 虽然不影响编译, 但结果恐怕不符合预期, 除非源文件中先包含 protobuf 相关头文件再包含此头文件.
There was a problem hiding this comment.
#include "brpc/options.pb.h"
这个应该包含了那个宏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build warning, protobuf ByteSize() is deprecated, use ByteSizeLong() instead