Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stream while max_buf_size < 0 #2360

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

chenbay
Copy link
Contributor

@chenbay chenbay commented Aug 25, 2023

What problem does this PR solve?

fix stream logic while options.max_buf_size < 0

_cur_buf_size is size_t, options.max_buf_size is int. options.max_buf_size 赋值 会导致错误的含义。

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenbay
Copy link
Contributor Author

chenbay commented Aug 25, 2023

@wwbmmm 帮忙看看,之前feat的一个问题。

@wwbmmm
Copy link
Contributor

wwbmmm commented Aug 30, 2023

LGTM

@serverglen serverglen merged commit 09f0916 into apache:master Sep 21, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants