Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-2412][Avatica] appveyor.yml for Windows CI (Appveyor) #65

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@snuyanzin
Copy link
Contributor

commented Jul 11, 2018

[CALCITE-2412][Avatica] appveyor.yml for Windows CI (Appveyor)

@asfgit asfgit force-pushed the apache:master branch from 2a80eec to 146d310 Sep 23, 2018

@F21

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

Hey @snuyanzin , I wanted to see if it's possible to merge this PR for avatica 1.13.0. Would you be able to rebase against master?

@snuyanzin snuyanzin force-pushed the snuyanzin:CALCITE_AVATICA_2412 branch from 4c6cf53 to 9c4e313 Nov 14, 2018

@snuyanzin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

I think it is possible as the PR contains only a new file which is not present in master => no conflicts should be observed.
Anyway I did rebase against master and also enabled jdk9/jdk10 for appveyor build (unfortunately it still does not support jdk11, jdk12).

If it is possible besides the merging of the PR it would be great to have turned on Avatica appveoyr built on commit with its own badge. I think I do not have rights to do it but I did it for my own fork.

By the way here it is the link to the last appveyor build related to this issue
https://ci.appveyor.com/project/snuyanzin/calcite-avatica

@F21

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

@snuyanzin Thanks for looking at this! I've asked infra to enable Appveyfor for the repo: https://issues.apache.org/jira/browse/INFRA-17249.

Once enabled, infra should give us a link to the appveyor build page.

Can you also squash your commits and rename the commit message to [CALCITE-2412] ...commit message here...?

@snuyanzin snuyanzin force-pushed the snuyanzin:CALCITE_AVATICA_2412 branch 2 times, most recently from 807512d to 069cea1 Nov 14, 2018

@snuyanzin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

Squashed commits and changed commit message
Please let me know if it is ok or not

@F21

This comment has been minimized.

Copy link
Member

commented Nov 14, 2018

Thanks @snuyanzin ! That looks great! When infra enables appveyor (they should post a reply in INFRA-17249), can you add the badge to the readme and squash again? Then just merge the PR as everything else looks good to me 👍

@snuyanzin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

When infra enables appveyor (they should post a reply in INFRA-17249), can you add the badge to the readme and squash again?

Yes, sure. Have just become a watcher in the mentioned ticket. As soon as the url to Appveyor Avatica project will be published I will add the badge to the readme and squash.

@asfgit asfgit force-pushed the apache:master branch 5 times, most recently from ff37d89 to a8617e0 Nov 16, 2018

@snuyanzin snuyanzin force-pushed the snuyanzin:CALCITE_AVATICA_2412 branch from 069cea1 to 8e7864a Nov 19, 2018

[CALCITE-2412] Add appveyor.yml to have tests on Windows against jdk1…
….8, jdk9, jdk10

Add Appveyor badge
Add -DskipDockerCheck because of CALCITE-2385 and to make it sync with travis.yml

@snuyanzin snuyanzin force-pushed the snuyanzin:CALCITE_AVATICA_2412 branch from 8e7864a to 4fbdf5b Nov 19, 2018

@snuyanzin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

Squashed, rebased.
Added badge.
Added -DskipDockerCheck because of CALCITE-2385
Looks like working https://ci.appveyor.com/project/ApacheSoftwareFoundation/calcite-avatica/builds/20397074.

Currently it shows failing status as it points to master and changes are not merged I think.

@F21

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

Thank you @snuyanzin ! Looks great! Please merge when you have the chance to do it 😄

risdenk pushed a commit to risdenk/calcite-avatica that referenced this pull request Nov 19, 2018

[CALCITE-2412] Add appveyor.yml to have tests on Windows against jdk1…
….8, jdk9, jdk10

Add Appveyor badge
Add -DskipDockerCheck because of CALCITE-2385 and to make it sync with travis.yml

Close apache#65

@asfgit asfgit closed this in acc49bf Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.