From 8db4bc171f20bf5a0270f1989d5ea8684f2cb2e7 Mon Sep 17 00:00:00 2001
From: Kevin Risden <krisden@apache.org>
Date: Tue, 25 Sep 2018 12:38:32 -0400
Subject: [PATCH] [CALCITE-2594] Ensure forbiddenapis and maven-compiler use
 the correct JDK version

Close apache/calcite-avatica#74

Signed-off-by: Kevin Risden <krisden@apache.org>
---
 pom.xml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 244a52d725..0a2d6aff71 100644
--- a/pom.xml
+++ b/pom.xml
@@ -50,6 +50,11 @@ limitations under the License.
     </mailingList>
   </mailingLists>
   <properties>
+    <!-- Ensure that source and target version are overridden from base ASF POM.
+         This is also used by forbiddenapis to ensure correct signatures are loaded. -->
+    <maven.compiler.source>8</maven.compiler.source>
+    <maven.compiler.target>8</maven.compiler.target>
+
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <top.dir>${project.basedir}</top.dir>
     <avatica.release.version>${project.version}</avatica.release.version>
@@ -409,9 +414,9 @@ limitations under the License.
       </plugin>
       <plugin>
         <artifactId>maven-compiler-plugin</artifactId>
+        <!-- If you are looking to change source/target,
+             change the maven.compiler.{source,target} property -->
         <configuration>
-          <source>8</source>
-          <target>8</target>
           <compilerArgs>
             <arg>-Xlint:deprecation</arg>
           </compilerArgs>