Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-2704] Multilingual decoded problem #76

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@2k124
Copy link

commented Oct 11, 2018

"rawRequest = avaticautils.readfully (inputStream, buffer)" uses utf-8 encoding
"rawRequest = new String(rawrequest.getbytes (" iso-8859-1 "), "utf-8 ")" is decoded using iso-8859-1
Cause Chinese garble.

pufan
Modification of Chinese coding:
"rawRequest = avaticautils.readfully (inputStream, buffer)" uses utf-8 encoding
"rawRequest = new String(rawrequest.getbytes (" iso-8859-1 "), "utf-8 ")" is decoded using iso-8859-1
Cause Chinese gibberish.

@2k124 2k124 changed the title Modification of Chinese coding: fix multilingual garble problem Oct 11, 2018

@F21

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

Hey @2k124, thanks for opening this PR! Can you please open an issue on JIRA with a description of the issue and update the title of the PR to include the JIRA case number (ex. [CALCITE-XXXX]?

@michaelmior

This comment has been minimized.

Copy link
Member

commented Nov 11, 2018

Looks like a test would be great here too if possible so we can ensure nothing breaks this in the future.

@asfgit asfgit force-pushed the apache:master branch 5 times, most recently from ff37d89 to a8617e0 Nov 16, 2018

@2k124 2k124 changed the title fix multilingual garble problem [CALCITE-2704] Multilingual decoded problem Nov 26, 2018

@2k124

This comment has been minimized.

Copy link
Author

commented Nov 26, 2018

Hey @2k124, thanks for opening this PR! Can you please open an issue on JIRA with a description of the issue and update the title of the PR to include the JIRA case number (ex. [CALCITE-XXXX]?

OK. done

@F21

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

@2k124 Thanks for opening the JIRA case. Can you also add a test for this?

@F21

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

Superseded by #85

@F21 F21 closed this Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.