Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-2698] Use Docker Hub hooks to select Avatica version during image build and publish HSQLDB image #79

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@F21
Copy link
Member

F21 commented Nov 22, 2018

cc @joshelser If this is okay, I'll ask infra to create the calcite-avatica-hsqldb repo on docker hub.

@F21 F21 changed the title [CALCITE-2385] Use Docker Hub hooks to select Avatica version during image build and publish HSQLDB image [CALCITE-2698] Use Docker Hub hooks to select Avatica version during image build and publish HSQLDB image Nov 22, 2018

@F21 F21 force-pushed the F21:docker-hub-hooks branch 2 times, most recently from 0f699ea to 1443f00 Nov 22, 2018

@F21

This comment has been minimized.

Copy link
Member Author

F21 commented Nov 22, 2018

Appveyor failure looks like an intermittent failure.

@risdenk
Copy link
Contributor

risdenk left a comment

Changes look reasonable. I like the removal of the custom skipDockerCheck property. Also removes the need to keep groovy up to date. Have we tested that the hooks work? Seems like a cool feature.

@F21

This comment has been minimized.

Copy link
Member Author

F21 commented Nov 26, 2018

@risdenk I tested the hooks on my own docker repos. See the built images here:

This repository is the automated build of the avatica base image:

The following 2 are demonstrations of the HSQLDB flavor of avatica triggered using hooks:

@F21 F21 force-pushed the F21:docker-hub-hooks branch from 1443f00 to 1e4013e Nov 28, 2018

@asfgit asfgit merged commit 1e4013e into apache:master Nov 28, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@F21 F21 deleted the F21:docker-hub-hooks branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.