Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-3021] Equality of nested ROWs returns false for identical values #1183

Merged
merged 1 commit into from May 27, 2019

Conversation

@rubenada
Copy link
Contributor

rubenada commented Apr 26, 2019

No description provided.

Copy link
Contributor

danny0405 left a comment

+1

@rubenada

This comment has been minimized.

Copy link
Contributor Author

rubenada commented May 16, 2019

@julianhyde , you expressed some concerns in the original PR (which was merged and reverted), could you please take a look at this new one when you have some time?

@rubenada rubenada requested a review from julianhyde May 20, 2019
@rubenada rubenada changed the title [CALCITE-3021] ArrayEqualityComparer should use Arrays#deepEquals/deepHashCode instead of Arrays#equals/hashCode (Ruben Quesada Lopez) [CALCITE-3021] Equality of nested ROWs returns false for identical values May 22, 2019
@rubenada rubenada force-pushed the rubenada:CALCITE-3021 branch 2 times, most recently from 456db23 to c22d047 May 22, 2019
@rubenada rubenada force-pushed the rubenada:CALCITE-3021 branch from c22d047 to 63122df May 23, 2019
@michaelmior michaelmior merged commit ab40586 into apache:master May 27, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.