[CALCITE-3845] CASE WHEN expression with nullability CAST is considered as reduced wrongly in ReduceExpressionsRule #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunweilei
force-pushed
the
CALCITE-3845
branch
2 times, most recently
from
28d7154
to
0746873
Compare
|
LGTM |
chunweilei
added
the
LGTM-will-merge-soon
vlsi
reviewed
Mar 9, 2020
| @@ -302,6 +302,7 @@ public ProjectReduceExpressionsRule(Class<? extends Project> projectClass, | |||
| Lists.newArrayList(project.getProjects()); | |||
| if (reduceExpressions(project, expList, predicates, false, | |||
| matchNullability)) { | |||
| assert !project.getProjects().equals(expList); | |||
There was a problem hiding this comment.
Can you please add a message, so the failure looks human-readable?
vlsi
reviewed
Mar 9, 2020
Comment on lines
+3499
to
+3506
| final RexNode caseRexNode = rexBuilder.makeCall(SqlStdOperatorTable.CASE, | ||
| rexBuilder.makeCall(SqlStdOperatorTable.EQUALS, | ||
| rexBuilder.makeCall(SqlStdOperatorTable.MOD, ref, literal2), literal1), | ||
| rexBuilder.makeCall(SqlStdOperatorTable.LESS_THAN, ref, literal2), | ||
| rexBuilder.makeCall(SqlStdOperatorTable.EQUALS, | ||
| rexBuilder.makeCall(SqlStdOperatorTable.MOD, ref, literal3), literal2), | ||
| rexBuilder.makeCall(SqlStdOperatorTable.LESS_THAN, ref, literal1), | ||
| rexBuilder.makeCall(SqlStdOperatorTable.LESS_THAN, ref, literal3)); |
There was a problem hiding this comment.
This looks way too verbose :-/
There was a problem hiding this comment.
I wish I can provide a more simple case, but I cannot. Because CASE WHEN will be changed to OR in many cases and thus it will not reproduce the issue.
There was a problem hiding this comment.
What I mean is signal to noise ratio leaves much to be desired here.
The dance of rexBuilder.makeCall(SqlStdOperatorTable repeats again and again :(
…ed as reduced wrongly in ReduceExpressionsRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/CALCITE-3845