[CALCITE-4936] Generalize FilterCalcMergeRule and ProjectCalcMergeRule #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Like CalcMergeRule, use only Project, Filter and Calc interfaces, which will expand the range of their applying.
rubenada
reviewed
Dec 14, 2021
core/src/main/java/org/apache/calcite/rel/rules/ProjectCalcMergeRule.java
Show resolved
Hide resolved
zabetak
approved these changes
Dec 23, 2021
core/src/main/java/org/apache/calcite/rel/rules/ProjectCalcMergeRule.java
Show resolved
Hide resolved
|
|
@hsyuan ok for me, but please be aware that we are currently in code freeze since we are in the middle of building a new release. We could merge this patch once master re-opens. |
|
I will merge this in a few minutes. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2022
… accept any Filter/Project/Calc operator Close #2646
github-actions bot
pushed a commit
to zzxx-husky/calcite
that referenced
this pull request
Apr 11, 2022
… accept any Filter/Project/Calc operator Close apache#2646
aymeric-dispa
pushed a commit
to aymeric-dispa/calcite
that referenced
this pull request
Jul 23, 2022
… accept any Filter/Project/Calc operator Close apache#2646
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 11, 2022
… accept any Filter/Project/Calc operator Close apache#2646
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
… accept any Filter/Project/Calc operator Close apache#2646
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
… accept any Filter/Project/Calc operator Close apache#2646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CALCITE-4936] Generalize FilterCalcMergeRule and ProjectCalcMergeRule. Like CalcMergeRule, use only Project, Filter and Calc interfaces, which will expand the range of their applying.