Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CALCITE-1702] Support extended columns in DML #408

Closed
wants to merge 1 commit into from

Conversation

@kliewkliew
Copy link
Contributor

kliewkliew commented Mar 19, 2017

No description provided.

@@ -27,6 +29,18 @@
* @see SqlValidatorCatalogReader
*/
public interface SqlValidatorTable {

/**
* Holds a RexBuilder. Insulates SqlValidator implementations from Rex dependencies.

This comment has been minimized.

Copy link
@kliewkliew

kliewkliew Mar 27, 2017

Author Contributor

After the (upcoming) addendum to CALCITE-1666, we can remove RexBuilder completely from SqlValidatorImpl. But I'm not sure if this is much of an improvement since it just moves the RexBuilder dependency from SqlValidatorImpl to SqlValidatorTable.

@kliewkliew kliewkliew force-pushed the kliewkliew:CALCITE-1702 branch from 7b45241 to 8a70ed4 Mar 29, 2017
@kliewkliew kliewkliew force-pushed the kliewkliew:CALCITE-1702 branch from 8a70ed4 to 938a47a Mar 29, 2017
julianhyde added a commit to julianhyde/calcite that referenced this pull request Mar 30, 2017
@asfgit asfgit closed this in 8a1a287 Mar 30, 2017
ldming pushed a commit to ldming/mycalcite that referenced this pull request Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.