Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALCITE-2275: Using logical NOT operator in Join condition leads to m… #675

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@vdiravka
Copy link
Member

commented Apr 23, 2018

…istakenly push down this condition

  • Adding case with NOT operator for RelOptUtil#pushDownEqualJoinConditions() method;
  • Refactoring of two for-each loops into one;
  • Test case of successful inferring predicate with NULL in JOIN condition.
CALCITE-2275: Using logical NOT operator in Join condition leads to m…
…istakenly push down this condition

- Adding case with NOT operator for RelOptUtil#pushDownEqualJoinConditions() method;
- Refactoring of two for-each loops into one;
- Test case of successful inferring predicate with NULL in JOIN condition.
@@ -221,6 +206,17 @@ public RelOptPredicateList getPredicates(Project project,
projectPullUpPredicates.add(rexBuilder.makeCall(op, args));
}
}

This comment has been minimized.

Copy link
@zinking

zinking Apr 25, 2018

Contributor

what is purpose of moving this block ?

This comment has been minimized.

Copy link
@vdiravka

vdiravka Apr 25, 2018

Author Member

There were used two for-each loops for Ord.zip(project.getProjects(). But it is possible to use combined logic in one loop.
In result: the logic is preserved and complexity is little bit less

julianhyde added a commit to julianhyde/calcite that referenced this pull request Apr 25, 2018

@asfgit asfgit closed this in e78f8c6 Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.