From ffda35c5cc3fd06c1f1a95db042e9c2bef5605ef Mon Sep 17 00:00:00 2001 From: Daniel Matthews <58484522+uruwhy@users.noreply.github.com> Date: Wed, 16 Apr 2025 11:36:11 -0400 Subject: [PATCH 1/2] filter 0-score facts from operation source --- app/objects/c_operation.py | 1 + 1 file changed, 1 insertion(+) diff --git a/app/objects/c_operation.py b/app/objects/c_operation.py index 7f961d8f1..38d8688da 100644 --- a/app/objects/c_operation.py +++ b/app/objects/c_operation.py @@ -191,6 +191,7 @@ async def all_facts(self): seeded_facts = [] if self.source: seeded_facts = await data_svc_handle.get_facts_from_source(self.source.id) + seeded_facts = [f for f in seeded_facts if f.score > 0] learned_facts = await knowledge_svc_handle.get_facts(criteria=dict(source=self.id)) learned_facts = [f for f in learned_facts if f.score > 0] return seeded_facts + learned_facts From b723aaca99589df1515badd40bd81732f93ce118 Mon Sep 17 00:00:00 2001 From: Daniel Matthews <58484522+uruwhy@users.noreply.github.com> Date: Wed, 16 Apr 2025 12:39:02 -0400 Subject: [PATCH 2/2] add 0-score fact to unit test --- tests/objects/test_operation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/objects/test_operation.py b/tests/objects/test_operation.py index be95d9d16..357acc62b 100644 --- a/tests/objects/test_operation.py +++ b/tests/objects/test_operation.py @@ -190,7 +190,7 @@ def _make_agent(platform='windows', trusted=True, executor_name='psh'): @pytest.fixture def op_with_learning_and_seeded(ability, adversary, operation_agent, parse_datestring): - sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob')]) + sc = Source(id='3124', name='test', facts=[Fact(trait='domain.user.name', value='bob'), Fact(trait='domain.user.name', value='jane', score=0)]) op = Operation(id='6789', name='testC', agents=[], adversary=adversary, source=sc, use_learning_parsers=True) # patch operation to make it 'realistic' op.start = parse_datestring(OP_START_TIME)