Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a wrap component to wrap single tenant component #503

Merged
merged 2 commits into from Sep 25, 2020
Merged

Create a wrap component to wrap single tenant component #503

merged 2 commits into from Sep 25, 2020

Conversation

lburgazzoli
Copy link
Contributor

Release Note

NONE

@lburgazzoli
Copy link
Contributor Author

Workaround for #495

oscerd
oscerd requested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but the module name is wrong

camel-k-runtime-bom/pom.xml Outdated Show resolved Hide resolved
nicolaferraro
nicolaferraro requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it's not so bad as workaround..

camel-k-runtime-bom/pom.xml Outdated Show resolved Hide resolved
@lburgazzoli lburgazzoli force-pushed the camel-wrap branch 9 times, most recently from dec67c4 to cb0ba6a Compare September 24, 2020 18:12
@lburgazzoli lburgazzoli marked this pull request as ready for review September 24, 2020 18:16
@lburgazzoli
Copy link
Contributor Author

@oscerd @nicolaferraro mind doing a new review ?

@lburgazzoli lburgazzoli added this to the 1.5.0 milestone Sep 25, 2020
@lburgazzoli lburgazzoli merged commit cd744fa into apache:master Sep 25, 2020
@lburgazzoli lburgazzoli deleted the camel-wrap branch September 25, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro requested changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lburgazzoli @nicolaferraro @oscerd