Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump handlebars from 4.7.6 to 4.7.7 in /docs #808

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 5, 2022

Bumps handlebars from 4.7.6 to 4.7.7.

Changelog

Sourced from handlebars's changelog.

v4.7.7 - February 15th, 2021

  • fix weird error in integration tests - eb860c0
  • fix: check prototype property access in strict-mode (#1736) - b6d3de7
  • fix: escape property names in compat mode (#1736) - f058970
  • refactor: In spec tests, use expectTemplate over equals and shouldThrow (#1683) - 77825f8
  • chore: start testing on Node.js 12 and 13 - 3789a30

(POSSIBLY) BREAKING CHANGES:

  • the changes from version 4.6.0 now also apply in when using the compile-option "strict: true". Access to prototype properties is forbidden completely by default, specific properties or methods can be allowed via runtime-options. See #1633 for details. If you are using Handlebars as documented, you should not be accessing prototype properties from your template anyway, so the changes should not be a problem for you. Only the use of undocumented features can break your build.

That is why we only bump the patch version despite mentioning breaking changes.

Commits

Commits
  • a9a8e40 v4.7.7
  • e66aed5 Update release notes
  • 7d4d170 disable IE in Saucelabs tests
  • eb860c0 fix weird error in integration tests
  • b6d3de7 fix: check prototype property access in strict-mode (#1736)
  • f058970 fix: escape property names in compat mode (#1736)
  • 77825f8 refator: In spec tests, use expectTemplate over equals and shouldThrow (#1683)
  • 3789a30 chore: start testing on Node.js 12 and 13
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 5, 2022
@orpiske
Copy link
Contributor

orpiske commented Jun 23, 2022

@zregvart @lburgazzoli @oscerd I don't know much about the way we build the docs, but I am wondering if this is OK. Wdyt?

@zregvart
Copy link
Member

@zregvart @lburgazzoli @oscerd I don't know much about the way we build the docs, but I am wondering if this is OK. Wdyt?

Not sure if handlebars are used here at all, IIRC its used in the Antora site build, so perhaps it was brought here by preview. We're using 4.7.5 in the camel-website. I don't see an issue with upgrading a patch version here.

@orpiske
Copy link
Contributor

orpiske commented Jun 23, 2022

@zregvart thanks for the explanation! So, I guess it should be safe to merge. I'll ask the bot for a rebase and we can see how it goes. Thanks!

@orpiske
Copy link
Contributor

orpiske commented Jun 23, 2022

@dependabot rebase

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](handlebars-lang/handlebars.js@v4.7.6...v4.7.7)

---
updated-dependencies:
- dependency-name: handlebars
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/docs/handlebars-4.7.7 branch from 3a2ee49 to b6b36e5 Compare June 23, 2022 12:15
@orpiske orpiske merged commit bda6692 into main Jun 24, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/docs/handlebars-4.7.7 branch June 24, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants