Support camel 3.0.0 M3 #79 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
force-pushed
the
github-79-camel-3.0.0-M3
branch
from
aeb320c
to
1abe55b
Compare
oscerd
approved these changes
Jun 10, 2019
davsclaus
approved these changes
Jun 10, 2019
| import java.util.List; | ||
| import java.util.Properties; | ||
|
|
||
| import org.apache.camel.CamelContext; | ||
| import org.apache.camel.Ordered; | ||
| import org.apache.camel.component.properties.PropertiesComponent; | ||
| import org.apache.camel.impl.DefaultCamelContext; | ||
| import org.apache.camel.impl.ExplicitCamelContextNameStrategy; | ||
| import org.apache.camel.impl.engine.ExplicitCamelContextNameStrategy; |
There was a problem hiding this comment.
If you need this one for being able to set the name easily, then the setName api is now public. But I think this may be from M4 onwards
There was a problem hiding this comment.
yup, will clean up once M4 will be out out
davsclaus
reviewed
Jun 10, 2019
| } | ||
|
|
||
| public static int bindProperties(Properties properties, Object target, String prefix) { | ||
| public static int bindProperties(CamelContext context, Properties properties, Object target, String prefix) { |
There was a problem hiding this comment.
We could likely add API on PropertyBindingSupport to support prefix so we have it OOTB, fell free to log a JIRA
There was a problem hiding this comment.
yes I'm working on this
squakez
pushed a commit
to squakez/camel-k-runtime
that referenced
this pull request
Mar 27, 2023
…pache#81) PNC build is failing because it is trying to use a productized version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.