Restore flow type as object?

[nicolaferraro]

I've seen now this commit @astefanutti : 1b95c5a

The flow type was "special" meaning that it allowed to create an integration like:

kind: Integration
apiVersion: camel.apache.org/v1
spec:
  flows:
  - from:
      uri: timer
      steps:
      - log:
        message: Hello

While, setting it as string the integration becomes "probably" like:

kind: Integration
apiVersion: camel.apache.org/v1
spec:
  flows:
  - |-
    from:
      uri: timer
      steps:
      - log:
        message: Hello

I don't think we have e2e tests (but we should add them). In terms of JSONSchema, it was an array of objects, now it's an array of strings.

The reason why this was important is because the Integration object was a unique YAML (also convertible to json) and when @lburgazzoli completes the YAML schema for validation, also the integration object can have autocompletion/verification by tooling.. And that is also more important for Kamelets..

Does the conversion to string affect everything as I've described @astefanutti ?

[astefanutti]

Sorry, I failed to proactively warn you about this, but knew it would soon come back to haunt me :)

The previous type Flow map[string]interface{} was getting into the way of enabling CRD generation, and also leads to the question of schema validation.

I initially used type Flow json.RawMessage in 45bc5e9, and I fail to remember why I ultimately decided to go for type Flow string. I think it was just more convenient to use, without more context. While it worked, you're right it's not transparent from a schema standpoint.

I think using json.RawMessage or runtime.RawExtension should be less disruptive and enable to get back to what we had before.

More context can be found in kubernetes-sigs/controller-tools#294.