Should 'kamel uninstall --all' also delete camel-k-registry-secret?

[tadayosi]

Currently kamel uninstall --all doesn't delete camel-k-registry-secret if it was generated with kamel install --registry ....

$ kamel uninstall --all 
Camel K Integration Platform removed from namespace default
Camel K Config Maps removed from namespace default
Camel K Operator removed from namespace default
Camel K Role Bindings removed from namespace default
Camel K Roles removed from namespace default
Camel K Service Accounts removed from namespace default
Camel K Custom Resource Definitions removed from cluster
Camel K Cluster Role Bindings removed from cluster
Camel K Cluster Roles removed from cluster

$ kubectl get secrets 
NAME                      TYPE                                  DATA   AGE
camel-k-registry-secret   kubernetes.io/dockerconfigjson        1      14h
default-token-48wb7       kubernetes.io/service-account-token   3      178d
...

Maybe it should remove the registry and also provide an option --skip-registry for users who don't want it to be removed.

[nicolaferraro]

Yes, sounds good, I think we add some labels to detect if it's generated by us, btw that name is usually used only by our CLI

[tadayosi]

@nicolaferraro Thanks. So maybe should we add a label app=camel-k for the generated secret and clean up them if they have the label under uninstalling?

[tadayosi]

Fixed.