Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consistent env var management in traits #291

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@lburgazzoli
Copy link
Contributor

commented Dec 13, 2018

With this PR I've tried to have a single way for setting env vars inside traits as we have Environment::EnvVar (not a nice name identifier) but it is limited as it does not support setting env vars using the downward API.

@lburgazzoli lburgazzoli requested a review from nicolaferraro Dec 13, 2018

@nicolaferraro nicolaferraro merged commit 7313fa4 into apache:master Dec 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lburgazzoli lburgazzoli deleted the lburgazzoli:env branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.