-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to operator-sdk 0.3.0 #315
Migrate to operator-sdk 0.3.0 #315
Conversation
just wondering: should we create a k8sclient package with a global client and some utilities instead of passing a client instance similar to the old operator sdk? |
8c3c3e5
to
154b9b5
Compare
Yes, now I've added a client-wrapper package that simplifies things a bit. But I'm not fully convinced on switching to the old "static var" approach... |
what are the cons? |
Client is injected by the controller runtime into the user controllers each time a reconciliation should be executed. Saving it to a global location and using it from there does not seem so clean to me... Now you can assume it's always the same client, but what if it changes later (e.g. because of a periodic cache reset)? |
now it’s more clear, thx |
4d3465d
to
a2142a5
Compare
Only thing missing seems to be (lupus in fabula) a cache reset in the out-of-cluster client during installation, otherwise |
3784a4e
to
c2dff78
Compare
Fix #237
There are major changes between 0.0.7 and 0.3.x.