Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add .exe file extension to Windows kamel binary #636

Merged
merged 1 commit into from
Apr 25, 2019
Merged

fix: Add .exe file extension to Windows kamel binary #636

merged 1 commit into from
Apr 25, 2019

Conversation

jamesnetherton
Copy link
Contributor

Relates to #619.

Note: Since cross_compile.sh uses bash shell builtins pushd & popd, I changed the script shebang line to /bin/bash as /bin/sh could be symlinked to any shell (dash in the case of my system).

nicolaferraro
nicolaferraro approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@nicolaferraro nicolaferraro merged commit e628434 into apache:master Apr 25, 2019
@jamesnetherton jamesnetherton deleted the add-exe-extension branch April 25, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesnetherton @nicolaferraro @oscerd