-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ native support #1531
Comments
@ppalaga That was a quick reply ;-) I've already checked how the project is setup with extensions for quarkus and JVM. I also thought that the ActiveMQ extension would be a candidate to start with. Currently I am all new to Quarkus and Camel. But maybe I'll be able to contribute something. So far I've already created a simple project with a camel route on my local system. Building native worked and the program spits out the same text when run in JVM (dev) mode. |
Feel free to ask if you have specific questions. We also have a step by step guide for promoting extensions from JVM to native https://camel.apache.org/camel-quarkus/latest/contributor-guide/promote-jvm-to-native.html |
Oh, great. I'll check it out! |
I've forked the project and stared implementing an integration test. @ppalaga Would you assign this issue to me, then? |
@ppalaga I've started the integration test. But for some reason I cannot get it connect to the container. Obviously I am missing something but maybe you could direct me? https://github.com/apache/camel-quarkus/compare/master...Jeansen:rabbitmq-quarkus-native?expand=1 |
For the |
Great. Thanks. Now, I almost feel ashamed. I could have simply diffed the two POM files from the ActiveMQ test with mine ... 😊 and seen it. I just ran the test again and it was successful. Thank you 😃 |
@ppalaga I've created a PR. Please review. |
Addressed in 9752ff6 |
Resolved via #1567 |
Thanks again, @Jeansen ! |
Well, native support is indeed since 1.1.0, but the JVM-only extension was there since 1.0.0. So the extension as a whole is since 1.0.0. Should we make this more explicit on the web page? |
Hm, I am not sure. It might be of interest. At the moment there are not that many versions but in the future it might be of interest since which version native support is available. There might be situations where users simply cannot use the latest versions but have to stick to a specific version. So the argument would be not to use the latest but at least a the version that also supports native. Long story short: I would say yes and suggest to also ad a column for native :-) |
I think you are making a valid point. Could you please file a new issue for that? |
Contributions are welcome. Adding an integration test would the the first step. ActiveMQ is a good place to look how such an integration test should look like https://github.com/apache/camel-quarkus/tree/master/integration-tests/activemq
The text was updated successfully, but these errors were encountered: