-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XSLT extension does not work with file: URIs #428
Comments
Not very sure if it make sense as the file need to be compiled at build time so it may be better to require the file to be available as classpath thing so it does not change between the build phase and the runtime execution of the app |
I have a fix. It does not work for any URI that contains slashes. Has to do with how we produce the translet name.
Yes, the limitation is there for any kind of URI. We state in the docs that the resources have to be available at build time, but we should perhaps make it even more explicit saying that they are compiled at build time and fully ignored at runtime. If we document it properly, I see no reason why file:, http:, and other kinds of URIs should not be supported. WDYT? |
As far as I remember the stack (camel or xslt engine) still try to access the file before determine if it needs to compile or reuse classes so having something served through http would still lead to some possible slow actions and errors. |
Ah, indeed, I can see it now. My understanding is that runtime XSLT loading cannot work because it requires a class to get loaded. If this is really the case, accessing the XSLT source at runtime could be seen as a bug, shouldn't it? I mean that could be fixed easily by downloading and embedding the content of every source URI at build time. |
Yes, what I think is that we should enhance the component to let us filter what protocols we support so in quarkus we'll support classpath only, then about compiling the source yes, it can be everywhere and embedded in the resulting image but I do not know if it is something that depends on us or is a developer task |
I just tried to extend the XsltTest with a
file:
use case and it fails. Let me try to fix it.The text was updated successfully, but these errors were encountered: