Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the PlatformHttpComponent is registered before the routes are started #230

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Oct 6, 2019

Fixes #218

@asf-ci

This comment has been minimized.

Copy link

asf-ci commented Oct 6, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/209/

…started #218
@lburgazzoli lburgazzoli force-pushed the lburgazzoli:github-218 branch from 4d619d1 to 5e9ea01 Oct 6, 2019
@asf-ci

This comment has been minimized.

Copy link

asf-ci commented Oct 6, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/camel-quarkus-pr/210/

@oscerd
oscerd approved these changes Oct 6, 2019
@oscerd oscerd merged commit fcd8de3 into apache:master Oct 6, 2019
1 check passed
1 check passed
default SUCCESS 69 tests run, 4 skipped, 0 failed.
Details
@lburgazzoli lburgazzoli deleted the lburgazzoli:github-218 branch Oct 7, 2019
Copy link
Contributor

ppalaga left a comment

Questions inline plus a followup PR #237


@Record(ExecutionTime.RUNTIME_INIT)
@BuildStep
CamelRuntimeRegistryBuildItem bindRuntimeBeransToRegistry(

This comment has been minimized.

Copy link
@ppalaga

ppalaga Oct 7, 2019

Contributor

s/bindRuntimeBeransToRegistry/bindRuntimeBeansToRegistry/

@@ -151,6 +173,9 @@ CamelMainBuildItem main(
void start(
CamelMainRecorder recorder,
CamelMainBuildItem main,
// TODO: keep this as placeholder to ensure the registry is fully configured

This comment has been minimized.

Copy link
@ppalaga

ppalaga Oct 7, 2019

Contributor

Is there really anything TODO? I mean this looks like a valid long term comment without the TODO prefix. Plus there are at least two typos there.

.jsonPath();

//assertThat(p.getString(PlatformHttpConstants.PLATFORM_HTTP_ENGINE_NAME)).isEqualTo(QuarkusPlatformHttpEngine.class.getName());
//assertThat(p.getString(PlatformHttpConstants.PLATFORM_HTTP_COMPONENT_NAME)).isEqualTo(PlatformHttpComponent.class.getName());

This comment has been minimized.

Copy link
@ppalaga

ppalaga Oct 7, 2019

Contributor

Should these two lines really stay commented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.