Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some yarn problems #652

Closed
djencks opened this issue Oct 25, 2021 · 1 comment
Closed

Fix some yarn problems #652

djencks opened this issue Oct 25, 2021 · 1 comment
Assignees

Comments

@djencks
Copy link
Contributor

djencks commented Oct 25, 2021

  • explicitly set nodeLinker to "pnp" to avoid interference from .yarnrc.yml in parent directories
  • fail pr builds if yarn.lock has changed on install (using --immutable)
  • allow checkins of dependency changes from non-linux systems by adding a yarn rebuild step to jenkinsfile.
    (the promise of yarn pnp seems to be partial: stuff in .yarn/unplugged is platform specific and breaks the build on other platforms)

I expect to add some scripts to root package.json to make some of this easier to maintain.

@djencks djencks self-assigned this Oct 25, 2021
@djencks
Copy link
Contributor Author

djencks commented Oct 25, 2021

I'm not sure why merging #653 didn't close this.

@djencks djencks closed this as completed Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant