From 475fd395800015819567629460723aa35f848ff5 Mon Sep 17 00:00:00 2001 From: Otavio Rodolfo Piske Date: Wed, 22 May 2024 13:48:25 +0200 Subject: [PATCH] CAMEL-20785: move replaceFromEndpoints and make reusable --- .../camel/test/junit5/CamelTestSupport.java | 17 ++------------- .../junit5/util/CamelContextTestHelper.java | 21 +++++++++++++++++++ 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java index e4ac89e944afd..cda6d71688754 100644 --- a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java +++ b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/CamelTestSupport.java @@ -34,8 +34,6 @@ import org.apache.camel.ProducerTemplate; import org.apache.camel.RoutesBuilder; import org.apache.camel.Service; -import org.apache.camel.builder.AdviceWith; -import org.apache.camel.builder.AdviceWithRouteBuilder; import org.apache.camel.builder.RouteBuilder; import org.apache.camel.component.mock.MockEndpoint; import org.apache.camel.impl.DefaultCamelContext; @@ -459,7 +457,7 @@ protected void doSetUp() throws Exception { tryStartCamelContext(); } else { - replaceFromEndpoints(); + CamelContextTestHelper.replaceFromEndpoints(context, fromEndpoints); LOG.debug("Using route builder from the created context: {}", context); } LOG.debug("Routing Rules are: {}", context.getRoutes()); @@ -483,7 +481,7 @@ private void setupRoutes() throws Exception { CamelContextTestHelper.setupRoutes(context, builders); - replaceFromEndpoints(); + CamelContextTestHelper.replaceFromEndpoints(context, fromEndpoints); } private void tryStartCamelContext() throws Exception { @@ -513,17 +511,6 @@ private void configurePropertiesComponent() { CamelContextTestHelper.configurePropertiesComponent(context, extra, new JunitPropertiesSource(globalStore), ignore); } - private void replaceFromEndpoints() throws Exception { - for (final Map.Entry entry : fromEndpoints.entrySet()) { - AdviceWith.adviceWith(context.getRouteDefinition(entry.getKey()), context, new AdviceWithRouteBuilder() { - @Override - public void configure() { - replaceFromWith(entry.getValue()); - } - }); - } - } - private boolean isRouteCoverageEnabled() { return Boolean.parseBoolean(System.getProperty(ROUTE_COVERAGE_ENABLED, "false")) || isDumpRouteCoverage(); } diff --git a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/util/CamelContextTestHelper.java b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/util/CamelContextTestHelper.java index af9d836a6db9c..92422328c9b7c 100644 --- a/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/util/CamelContextTestHelper.java +++ b/components/camel-test/camel-test-junit5/src/main/java/org/apache/camel/test/junit5/util/CamelContextTestHelper.java @@ -17,6 +17,7 @@ package org.apache.camel.test.junit5.util; +import java.util.Map; import java.util.Properties; import org.apache.camel.CamelContext; @@ -25,11 +26,14 @@ import org.apache.camel.RoutesBuilder; import org.apache.camel.Service; import org.apache.camel.ServiceStatus; +import org.apache.camel.builder.AdviceWith; +import org.apache.camel.builder.AdviceWithRouteBuilder; import org.apache.camel.component.mock.InterceptSendToMockEndpointStrategy; import org.apache.camel.component.mock.MockEndpoint; import org.apache.camel.impl.DefaultCamelContext; import org.apache.camel.impl.debugger.DefaultDebugger; import org.apache.camel.model.Model; +import org.apache.camel.model.ModelCamelContext; import org.apache.camel.spi.Breakpoint; import org.apache.camel.spi.PropertiesComponent; import org.apache.camel.spi.PropertiesSource; @@ -200,4 +204,21 @@ public static void startCamelContextOrService(CamelContext context, Service came CamelContextTestHelper.startCamelContext(context); } } + + /** + * Replaces the 'from' endpoints of the given context with the ones from the provided map + * @param context the context to have the 'from' endpoints replaced + * @param fromEndpoints the map with the new endpoint Uris + * @throws Exception + */ + public static void replaceFromEndpoints(ModelCamelContext context, Map fromEndpoints) throws Exception { + for (final Map.Entry entry : fromEndpoints.entrySet()) { + AdviceWith.adviceWith(context.getRouteDefinition(entry.getKey()), context, new AdviceWithRouteBuilder() { + @Override + public void configure() { + replaceFromWith(entry.getValue()); + } + }); + } + } }