From bcaddc146fc74b3299d89f3532f9a657e4469487 Mon Sep 17 00:00:00 2001 From: Preben Asmussen Date: Sat, 25 Jul 2015 14:32:18 +0200 Subject: [PATCH] TcpDataWriter should use TcpInput class to attach to socket --- .../camel/component/splunk/support/TcpDataWriter.java | 8 ++++---- .../java/org/apache/camel/component/splunk/Helper.java | 7 +++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/TcpDataWriter.java b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/TcpDataWriter.java index 511d39b76203f..4f2cb16718e7c 100644 --- a/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/TcpDataWriter.java +++ b/components/camel-splunk/src/main/java/org/apache/camel/component/splunk/support/TcpDataWriter.java @@ -20,8 +20,9 @@ import java.net.Socket; import com.splunk.Args; -import com.splunk.Input; import com.splunk.Service; +import com.splunk.TcpInput; + import org.apache.camel.component.splunk.SplunkEndpoint; public class TcpDataWriter extends SplunkDataWriter { @@ -37,14 +38,13 @@ public void setPort(int port) { @Override protected Socket createSocket(Service service) throws IOException { - Input input = service.getInputs().get(String.valueOf(port)); + TcpInput input = (TcpInput)service.getInputs().get(String.valueOf(port)); if (input == null) { throw new RuntimeException("no input defined for port " + port); } if (input.isDisabled()) { throw new RuntimeException(String.format("input on port %d is disabled", port)); } - Socket socket = service.open(port); - return socket; + return input.attach(); } } diff --git a/components/camel-splunk/src/test/java/org/apache/camel/component/splunk/Helper.java b/components/camel-splunk/src/test/java/org/apache/camel/component/splunk/Helper.java index 87ecb0169cbe7..55b5b812e0239 100644 --- a/components/camel-splunk/src/test/java/org/apache/camel/component/splunk/Helper.java +++ b/components/camel-splunk/src/test/java/org/apache/camel/component/splunk/Helper.java @@ -23,13 +23,12 @@ import com.splunk.Args; import com.splunk.Index; import com.splunk.IndexCollection; -import com.splunk.Input; import com.splunk.InputCollection; import com.splunk.Service; +import com.splunk.TcpInput; import org.apache.camel.CamelContext; -import static org.mockito.Matchers.anyInt; import static org.mockito.Matchers.anyString; import static org.mockito.Matchers.isA; import static org.mockito.Mockito.mock; @@ -69,8 +68,8 @@ private void mockSplunkWriterApi() { when(service.getIndexes()).thenReturn(indexColl); InputCollection inputCollection = mock(InputCollection.class); when(service.getInputs()).thenReturn(inputCollection); - Input input = mock(Input.class); - when(service.open(anyInt())).thenReturn(socket); + TcpInput input = mock(TcpInput.class); + when(input.attach()).thenReturn(socket); when(inputCollection.get(anyString())).thenReturn(input); when(indexColl.get(anyString())).thenReturn(index); when(index.attach(isA(Args.class))).thenReturn(socket);