fix CAMEL-12149 ensure the CONTENT_TYPE header can be retrieved #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davsclaus
reviewed
Jan 17, 2018
| @@ -164,6 +164,12 @@ protected void invokeAsyncHttpClient(Exchange exchange, final AsyncCallback call | |||
| setupClientMatrix(client, exchange); | |||
| setupClientQueryAndHeaders(client, exchange); | |||
|
|
|||
| // ensure the CONTENT_TYPE header can be retrieved | |||
There was a problem hiding this comment.
We have the null on the other side as out standard with the Apache Camel code. Do you mind flipping them around.
|
Can't we use ObjectHelper? |
|
Yeah ObjectHelper.isEmpty would also check for an empty string, however not sure if you would have a Content-Type header that would be a |
|
Claus, I made minor changes by using ObjectHelper, is that OK? or other concerns you may have? |
davsclaus
approved these changes
Jan 18, 2018
Croway
pushed a commit
to Croway/camel
that referenced
this pull request
Mar 14, 2024
[ENTESB-20951] Camel Mail Component doesn't use host/port information from session URI parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.