[backport camel-4.14.x] CAMEL-23575: camel-mongodb-gridfs - align Exchange header constant names with Camel naming convention#23486
Open
oscerd wants to merge 1 commit into
Conversation
…mes with Camel naming convention (apache#23413) Renames the values of the Exchange header constants in GridFsConstants to follow the standard Camel<Component><Field> naming convention used across the rest of the component catalog, bringing camel-mongodb-gridfs in line with the parent camel-mongodb component (MongoDbConstants.OPERATION_HEADER = "CamelMongoDbOperation"). The Java field names are unchanged so routes/code referencing the constants symbolically continue to work as-is: gridfs.operation -> CamelGridFsOperation gridfs.metadata -> CamelGridFsMetadata gridfs.chunksize -> CamelGridFsChunkSize gridfs.objectid -> CamelGridFsObjectId gridfs.fileid -> CamelGridFsFileId The cascading rename of the auto-generated Endpoint DSL accessors on GridFsHeaderNameBuilder is included (gridfsOperation() -> gridFsOperation(), etc.) along with the regenerated component catalog. The upgrade-guide entry for this change is added on the main branch (per the backport upgrade-guide policy). Consistent with the same alignment applied to camel-lucene (CAMEL-23509), camel-jgroups (CAMEL-23510), camel-jgroups-raft (CAMEL-23511), and camel-cxf (CAMEL-23526). Reported by Claude Code on behalf of Andrea Cosentino. (cherry picked from commit 8f0b1ac) Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
added
the
backport
gnodet
approved these changes
May 24, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean backport of #23413 onto camel-4.14.x. I reviewed the original PR and the companion 4.18.x backport (#23473) — this cherry-pick is byte-identical in substance.
What I checked:
- Constant renames: All 5 GridFS header values correctly renamed from
gridfs.*→CamelGridFs*, following the standardCamel<Component><Field>convention. Java field names unchanged — routes using symbolic references are unaffected. - Generated files: Both catalog JSONs (
mongodb-gridfs.json) and the Endpoint DSL factory (GridFsEndpointBuilderFactory.java) are regenerated consistently. Method names updated (gridfsMetadata()→gridFsMetadata(), etc.). - Upgrade guide: Correctly deferred to a doc-sync PR on
mainper the backport upgrade-guide policy. - No drift: Single cherry-pick commit, clean application.
LGTM.
Claude Code on behalf of Guillaume Nodet
davsclaus
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #23413 onto
camel-4.14.xCherry-pick of #23413 (CAMEL-23575) onto the 4.14.x maintenance branch for the 4.14.8 release line. The
GridFsConstantsheader-name values were byte-identical onmain,camel-4.18.xandcamel-4.14.x, so the rename applies cleanly.Renames (string values only; Java field names unchanged)
GRIDFS_OPERATIONgridfs.operationCamelGridFsOperationGRIDFS_METADATAgridfs.metadataCamelGridFsMetadataGRIDFS_CHUNKSIZEgridfs.chunksizeCamelGridFsChunkSizeGRIDFS_OBJECT_IDgridfs.objectidCamelGridFsObjectIdGRIDFS_FILE_ID_PRODUCEDgridfs.fileidCamelGridFsFileIdIncludes the cascading regen of the component catalog and the
GridFsHeaderNameBuilderEndpoint DSL accessors. Routes referencing the constants symbolically are unaffected.Upgrade guide
Per the backport upgrade-guide policy, the 4.14 upgrade-guide entry (
camel-4x-upgrade-guide-4_14.adoc) is added onmainin a separate doc-sync PR rather than on this maintenance branch.Original PR: #23413
Companion backport (4.18.x): #23473
Target branch:
camel-4.14.x(4.14.8)Test plan
_4_21.adoc->_4_14.adocupgrade-guide relocation (now handled onmain)mvn clean install -DskipTestsfrom repo root — green; no uncommitted regen driftBackport prepared by Claude Code on behalf of Andrea Cosentino.