diff --git a/core/camel-util/src/main/java/org/apache/camel/util/URISupport.java b/core/camel-util/src/main/java/org/apache/camel/util/URISupport.java index 84127b3a501fa..8ab513173e17c 100644 --- a/core/camel-util/src/main/java/org/apache/camel/util/URISupport.java +++ b/core/camel-util/src/main/java/org/apache/camel/util/URISupport.java @@ -443,7 +443,7 @@ public static URI createURIWithQuery(URI uri, String query) throws URISyntaxExce if (before != null) { s = before; } - if (query != null) { + if (query != null && !query.isEmpty()) { s = s + "?" + query; } if (!s.contains("#") && uri.getFragment() != null) { diff --git a/core/camel-util/src/test/java/org/apache/camel/util/URISupportTest.java b/core/camel-util/src/test/java/org/apache/camel/util/URISupportTest.java index b1e6d73c62951..48f908ba55d8e 100644 --- a/core/camel-util/src/test/java/org/apache/camel/util/URISupportTest.java +++ b/core/camel-util/src/test/java/org/apache/camel/util/URISupportTest.java @@ -185,6 +185,14 @@ public void testCreateURIWithQueryHasOneFragmentAndQueryParameter() throws Excep assertEquals("smtp://localhost?utm_campaign=launch#fragmentOne", resultUri.toString()); } + @Test + public void testCreateURIWithQueryEmptyQueryString() throws Exception { + URI uri = new URI("https://api.example.com/users/myuser/repos"); + URI resultUri = URISupport.createURIWithQuery(uri, ""); + assertNotNull(resultUri); + assertEquals("https://api.example.com/users/myuser/repos", resultUri.toString()); + } + @Test public void testNormalizeEndpointWithEqualSignInParameter() throws Exception { String out = URISupport.normalizeUri("jms:queue:foo?selector=somekey='somevalue'&foo=bar");