Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
CAMEL-14215: Adding camel-main-osgi. #3378
Oh I planned to do a little review. So on top of my head
Can we get this corrected. And also give it a new name for example
And then maybe add an example in the examples that uses this new stuff
Hi @davsclaus , Thank you for the review. Comments inline
Agree it is not using/extending camel--main. Naming is hard I was looking for something close conceptually. I like the suggestion camel-core-osgi-activator. Will update this.
Yes there are 2 different ways routes are added. At startup I check for existing RouteBuilder services registered and then afterward I use the service tracker to notify the context of new RouteBuilder services added later. I thought it would be more consistent to add all routes after starting. You mention that is not how it is normally done, is there a reason for this? Is my approach harmful? The idea of this is to allow camel to take advantage of OSGi's dynamic nature.
I might need more specific direction here. I do see camel-core-osgi takes a different approach to registering the osgi services. But I'm not sure if that's what you mean. Can you provide more details?
Thanks again for the review.