Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-16471 - Enable URL endpoint based Client Initialization #5319

Merged
merged 6 commits into from Apr 10, 2021

Conversation

hokutor
Copy link
Contributor

@hokutor hokutor commented Apr 8, 2021

  • Enabling Endpoint URL based SmnClient initialization beside the Region based

As of camel release version 3.9, camel-huaweicloud-smn component supports initializing the SMN client based on cloud region only.

As an alternative option, Huaweicloud SDK now supports initializing the endpoint based on fully qualified endpoint url as per the documentation here.
https://github.com/huaweicloud/huaweicloud-sdk-java-v3#31-initialize-the-serviceclient-with-specified-endpoint-top

We should have the same feature enabled for camel-huaweicloud-smn too

- Enabling Endpoint URL based SmnClient initialization beside the Region based
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note.

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note.

- Endpoint based client initialization has higher precedence than the region based configuration. Noting this in migration guide and updated endpoint documents
…nfiguration descriptions in SimpleNotificationEndpoint.java
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed something.

…lated configuration descriptions in SimpleNotificationEndpoint.java"

This reverts commit e6b794d.
@davsclaus davsclaus merged commit 600c6b2 into apache:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants