From 8182f949588cf4705a7a1e4114bb784f26c04e2e Mon Sep 17 00:00:00 2001 From: Gilvan Filho Date: Tue, 20 Dec 2022 21:39:27 -0300 Subject: [PATCH 1/5] (chores) camel-test: replace size() > 0 by !isEmpty() --- .../java/org/apache/camel/test/junit4/CamelTestSupport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java b/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java index aba28f0048679..b5ffcabfd5a90 100644 --- a/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java +++ b/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java @@ -625,7 +625,7 @@ private void logCoverageSummary(ManagedCamelContextMBean managedCamelContext) th builder.append("\t\tCamelContext (").append(managedCamelContext.getCamelId()).append(") total: ") .append(contextExchangesTotal).append("\n"); - if (uncoveredRoutes.size() > 0) { + if (!uncoveredRoutes.isEmpty()) { builder.append("\t\tUncovered routes: ").append(uncoveredRoutes.stream().collect(Collectors.joining(", "))) .append("\n"); } From 15e99589b3f2651d3fded6a0aa0c895ff001a4cc Mon Sep 17 00:00:00 2001 From: Gilvan Filho Date: Tue, 20 Dec 2022 21:43:58 -0300 Subject: [PATCH 2/5] (chores) camel-wal: replace size() > 0 by !isEmpty() --- .../src/main/java/org/apache/camel/component/wal/LogWriter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java b/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java index 92375ecb92dc9..17169dbe45677 100644 --- a/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java +++ b/components/camel-wal/src/main/java/org/apache/camel/component/wal/LogWriter.java @@ -150,7 +150,7 @@ public EntryInfo.CachedEntryInfo append(LogEntry entry) throws IOException { .filter(c -> c != null && c.layerInfo.getLayer() != transactionLog.currentLayer()) .map(e -> tryPersist(layerInfo, e.logEntry)).collect(Collectors.toList()); - if (collect.size() > 0) { + if (!collect.isEmpty()) { final EntryInfo lastOnLayer = collect.get(0); LOG.trace("Current pos is: {}", fileChannel.position()); From 1596a90d532223d59d2910b3b5b844f0ad903626 Mon Sep 17 00:00:00 2001 From: Gilvan Filho Date: Tue, 20 Dec 2022 21:46:06 -0300 Subject: [PATCH 3/5] (chores) camel-console: replace size() > 0 by !isEmpty() --- .../apache/camel/impl/console/DefaultDevConsoleRegistry.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java b/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java index c84337d47cc62..a3bb0e1dff855 100644 --- a/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java +++ b/core/camel-console/src/main/java/org/apache/camel/impl/console/DefaultDevConsoleRegistry.java @@ -179,7 +179,7 @@ public void loadDevConsoles(boolean force) { DefaultDevConsolesLoader loader = new DefaultDevConsolesLoader(camelContext); Collection col = loader.loadDevConsoles(); - if (col.size() > 0) { + if (!col.isEmpty()) { int added = 0; // register the loaded consoles for (DevConsole console : col) { From 2055fd29eb5fec752deacc8de92ef1cc8b9c4cd4 Mon Sep 17 00:00:00 2001 From: Gilvan Filho Date: Tue, 20 Dec 2022 21:48:56 -0300 Subject: [PATCH 4/5] (chores) camel-core-model: replace size() > 0 by !isEmpty() --- .../src/main/java/org/apache/camel/builder/AdviceWithTasks.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java b/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java index 0a42743c6f90c..5c90fda4e277f 100644 --- a/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java +++ b/core/camel-core-model/src/main/java/org/apache/camel/builder/AdviceWithTasks.java @@ -472,7 +472,7 @@ private static List> getOutputs(ProcessorDefinition no break; } } - if (outputs.size() >= 1 && allAbstract) { + if (!outputs.isEmpty() && allAbstract) { // if all outputs are abstract then get its last output, as outputs = outputs.get(outputs.size() - 1).getOutputs(); } From ba656d9cbc23689cdf05897e2c0875cba875b74f Mon Sep 17 00:00:00 2001 From: Gilvan Filho Date: Tue, 20 Dec 2022 21:52:03 -0300 Subject: [PATCH 5/5] (chores) camel-health: replace size() > 0 by !isEmpty() --- .../apache/camel/impl/health/DefaultHealthCheckRegistry.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java b/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java index 9d31fa631d31f..7db8874ccc52b 100644 --- a/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java +++ b/core/camel-health/src/main/java/org/apache/camel/impl/health/DefaultHealthCheckRegistry.java @@ -301,7 +301,7 @@ public void loadHealthChecks() { Collection col = loader.loadHealthChecks(); // register loaded health-checks col.forEach(this::register); - if (col.size() > 0) { + if (!col.isEmpty()) { String time = TimeUtils.printDuration(watch.taken(), true); LOG.debug("Health checks (scanned: {}) loaded in {}", col.size(), time); }