New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2196]carbontable should be taken from loadmodel during stream #1991

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@rahulforallp
Contributor

rahulforallp commented Feb 22, 2018

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? No

  • Any backward compatibility impacted? No

  • Document update required? No

  • Testing done NA

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 22, 2018

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3819/

@rahulforallp rahulforallp changed the title from [CARBONDATA-2196]carbontable should be taken from loadmodel to [CARBONDATA-2196]carbontable should be taken from loadmodel during stream Feb 22, 2018

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 22, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2574/

@ravipesala

This comment has been minimized.

Show comment
Hide comment
@ravipesala

ravipesala Feb 22, 2018

Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3608/

Contributor

ravipesala commented Feb 22, 2018

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3608/

@rahulforallp

This comment has been minimized.

Show comment
Hide comment
@rahulforallp

rahulforallp Feb 23, 2018

Contributor

retest this please

Contributor

rahulforallp commented Feb 23, 2018

retest this please

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 23, 2018

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3832/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 23, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2588/

@rahulforallp

This comment has been minimized.

Show comment
Hide comment
@rahulforallp

rahulforallp Feb 23, 2018

Contributor

retest this please

Contributor

rahulforallp commented Feb 23, 2018

retest this please

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 23, 2018

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3841/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 23, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2596/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 24, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2618/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 24, 2018

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3863/

@ravipesala

This comment has been minimized.

Show comment
Hide comment
@ravipesala

ravipesala Feb 24, 2018

Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3644/

Contributor

ravipesala commented Feb 24, 2018

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3644/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 27, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2685/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 27, 2018

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3929/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 27, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2687/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Feb 27, 2018

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3932/

@ravipesala

This comment has been minimized.

Show comment
Hide comment
@ravipesala

ravipesala Feb 27, 2018

Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3703/

Contributor

ravipesala commented Feb 27, 2018

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3703/

@ravipesala

This comment has been minimized.

Show comment
Hide comment
@ravipesala

ravipesala Feb 27, 2018

Contributor

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3705/

Contributor

ravipesala commented Feb 27, 2018

SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3705/

* @return
*/
public static String[] getLocalDataFolderLocation(String databaseName, String tableName,
public static String[] getLocalDataFolderLocation(CarbonTable carbonTable, String tableName,

This comment has been minimized.

@QiangCai

QiangCai Mar 1, 2018

Contributor

not require tableName

@QiangCai

QiangCai Mar 1, 2018

Contributor

not require tableName

This comment has been minimized.

@rahulforallp

rahulforallp Mar 1, 2018

Contributor

in case of Pre aggregate table, table name can be of child even though carbonTable object is for main table.

@rahulforallp

rahulforallp Mar 1, 2018

Contributor

in case of Pre aggregate table, table name can be of child even though carbonTable object is for main table.

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 1, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2762/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 1, 2018

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4006/

@QiangCai

This comment has been minimized.

Show comment
Hide comment
@QiangCai

QiangCai Mar 1, 2018

Contributor

LGTM

Contributor

QiangCai commented Mar 1, 2018

LGTM

return getLocalDataFolderLocation(carbonTable, tableName, taskId, partitionId,
segmentId, isCompactionFlow, isAltPartitionFlow);
}

This comment has been minimized.

@QiangCai

QiangCai Mar 2, 2018

Contributor

not required

@QiangCai

QiangCai Mar 2, 2018

Contributor

not required

This comment has been minimized.

@QiangCai

QiangCai Mar 2, 2018

Contributor

fixed

@QiangCai

QiangCai Mar 2, 2018

Contributor

fixed

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 2, 2018

Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4016/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 2, 2018

Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2772/

@QiangCai

This comment has been minimized.

Show comment
Hide comment
@QiangCai

QiangCai Mar 2, 2018

Contributor

retest this please

Contributor

QiangCai commented Mar 2, 2018

retest this please

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 2, 2018

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4019/

@CarbonDataQA

This comment has been minimized.

Show comment
Hide comment
@CarbonDataQA

CarbonDataQA commented Mar 2, 2018

Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2775/

@QiangCai

This comment has been minimized.

Show comment
Hide comment
@QiangCai

QiangCai Mar 2, 2018

Contributor

LGTM

Contributor

QiangCai commented Mar 2, 2018

LGTM

@asfgit asfgit closed this in 65471f2 Mar 2, 2018

zzcclp added a commit to zzcclp/carbondata that referenced this pull request Mar 2, 2018

asfgit pushed a commit that referenced this pull request Mar 3, 2018

anubhav100 added a commit to anubhav100/incubator-carbondata that referenced this pull request Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment