From 35d8f534270f6d78e4242082174214769a88e272 Mon Sep 17 00:00:00 2001 From: Brandon Williams Date: Thu, 12 May 2011 22:27:44 +0000 Subject: [PATCH] Make help and validation types match in cassandra-cli. Patch by Pavel Yaskevich, revewied by Jackson Chung for CASSANDRA-2615 git-svn-id: https://svn.apache.org/repos/asf/cassandra/branches/cassandra-0.8@1102487 13f79535-47bb-0310-9956-ffa450edef68 --- .../org/apache/cassandra/cli/CliClient.java | 18 +++++++++++------- .../org/apache/cassandra/cli/CliHelp.yaml | 14 +++++++------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/src/java/org/apache/cassandra/cli/CliClient.java b/src/java/org/apache/cassandra/cli/CliClient.java index 58d24e7dc95a..fcac3da5a4f1 100644 --- a/src/java/org/apache/cassandra/cli/CliClient.java +++ b/src/java/org/apache/cassandra/cli/CliClient.java @@ -61,13 +61,14 @@ public class CliClient */ public enum Function { - BYTES (BytesType.instance), - INTEGER (IntegerType.instance), - LONG (LongType.instance), - LEXICALUUID (LexicalUUIDType.instance), - TIMEUUID (TimeUUIDType.instance), - UTF8 (UTF8Type.instance), - ASCII (AsciiType.instance); + BYTES (BytesType.instance), + INTEGER (IntegerType.instance), + LONG (LongType.instance), + LEXICALUUID (LexicalUUIDType.instance), + TIMEUUID (TimeUUIDType.instance), + UTF8 (UTF8Type.instance), + ASCII (AsciiType.instance), + COUNTERCOLUMN (CounterColumnType.instance); private AbstractType validator; @@ -1376,6 +1377,9 @@ private void executeAssumeStatement(Tree statement) return; } + // making string representation look property e.g. o.a.c.db.marshal.UTF8Type + defaultType = comparator.getClass().getName(); + if (assumptionElement.equals("COMPARATOR")) { columnFamily.setComparator_type(defaultType); diff --git a/src/resources/org/apache/cassandra/cli/CliHelp.yaml b/src/resources/org/apache/cassandra/cli/CliHelp.yaml index 95924edeb3ed..694ce8d417b0 100644 --- a/src/resources/org/apache/cassandra/cli/CliHelp.yaml +++ b/src/resources/org/apache/cassandra/cli/CliHelp.yaml @@ -1074,13 +1074,13 @@ commands: - type: Validator type to use when processing values. Supported values are: - - AsciiType - - BytesType - - CounterColumnType (distributed counter column) - - IntegerType (a generic variable-length integer type) - - LexicalUUIDType - - LongType - - UTF8Type + - ascii + - bytes + - counterColumn (distributed counter column) + - integer (a generic variable-length integer type) + - lexicalUUID + - long + - utf8 It is also valid to specify the fully-qualified class name to a class that extends org.apache.Cassandra.db.marshal.AbstractType.