From bcffd1a635d659738304d19c207dda0ab62bcda6 Mon Sep 17 00:00:00 2001 From: Stefan Miklosovic Date: Tue, 6 Dec 2022 15:49:09 +0100 Subject: [PATCH] Do not spam the logs with MigrationCoordinator not able to pull schemas on bootstrap patch by Stefan Miklosovic; reviewed by Brandon Williams for CASSANDRA-18096 --- CHANGES.txt | 1 + .../org/apache/cassandra/service/MigrationCoordinator.java | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGES.txt b/CHANGES.txt index 2543f44e852d..5b9afb72a21f 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -1,4 +1,5 @@ 3.0.29 + * Do not spam the logs with MigrationCoordinator not able to pull schemas on bootstrap (CASSANDRA-18096) * Fix incorrect resource name in LIST PERMISSION output (CASSANDRA-17848) * Suppress CVE-2022-41854 and similar (CASSANDRA-18083) * Fix running Ant rat targets without git (CASSANDRA-17974) diff --git a/src/java/org/apache/cassandra/service/MigrationCoordinator.java b/src/java/org/apache/cassandra/service/MigrationCoordinator.java index da69a6807d0e..83d60f2fff7f 100644 --- a/src/java/org/apache/cassandra/service/MigrationCoordinator.java +++ b/src/java/org/apache/cassandra/service/MigrationCoordinator.java @@ -62,11 +62,13 @@ import org.apache.cassandra.net.MessagingService; import org.apache.cassandra.schema.SchemaKeyspace; import org.apache.cassandra.utils.FBUtilities; +import org.apache.cassandra.utils.NoSpamLogger; import org.apache.cassandra.utils.concurrent.WaitQueue; public class MigrationCoordinator { private static final Logger logger = LoggerFactory.getLogger(MigrationCoordinator.class); + private static final NoSpamLogger noSpamLogger = NoSpamLogger.getLogger(MigrationCoordinator.logger, 1, TimeUnit.MINUTES); private static final RuntimeMXBean runtimeMXBean = ManagementFactory.getRuntimeMXBean(); private static final Future FINISHED_FUTURE = Futures.immediateFuture(null); @@ -498,7 +500,7 @@ private void pullSchema(Callback callback) { if (!isAlive(callback.endpoint)) { - logger.warn("Can't send schema pull request: node {} is down.", callback.endpoint); + noSpamLogger.warn("Can't send schema pull request: node {} is down.", callback.endpoint); callback.fail(); return; }