Feature/apply use stringview #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
==========================================
+ Coverage 72.13% 72.21% +0.08%
==========================================
Files 234 234
Lines 39474 39611 +137
==========================================
+ Hits 28473 28605 +132
- Misses 11001 11006 +5
Continue to review full report at Codecov.
|
jermus67
approved these changes
Dec 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the std::string arguments in the (C++17) methods to std::string_view and if applicable also update the
std::string return types to std::string_view.
This make it possible to use std::string_view objects as input and as result use constructions like:
constexpr std::string_view MY_CONSTANT = "value";for constants.Currently string_view arguments are assumed to refer to null-terminated strings. This is essential the same as with handling
const char*arguments.Technically string_view objects can refer to not null-terminated strings and this is also detectable (using string_view::size() and looking for the '\0'), but expensive. IMO this is not really necessary. Mainly, because we also assume
const char*arguments are null-terminated.