Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9446: Marvin and integration-tests packages #1612

Closed
wants to merge 2 commits into from

Conversation

@rhtyd
Copy link
Member

commented Jul 20, 2016

This introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

Since Marvin may have its own dependencies, we're bundling the Marvin source tarball and installing it with pip in the post-installation script/phase.

This also fixed a build issue with using juniper-api maven repo.

/cc @swill @PaulAngus @jburwell @wido @bvbharat

@PaulAngus

This comment has been minimized.

Copy link
Member

commented Jul 20, 2016

@rohit is it worth putting into straight into the apachecloudstack repo (rather than apache/cloudstack).

Kind regards,

Paul Angus

VP Technology
paul.angus@shapeblue.com
www.shapeblue.com

From: Rohit Yadav [mailto:notifications@github.com]
Sent: 20 July 2016 07:28
To: apache/cloudstack cloudstack@noreply.github.com
Cc: Paul Angus paul.angus@shapeblue.com; Mention mention@noreply.github.com
Subject: [apache/cloudstack] packaging: Marvin and integration-tests packages (#1612)

This introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

/cc @swillhttps://github.com/swill @PaulAngushttps://github.com/PaulAngus @jburwellhttps://github.com/jburwell @widohttps://github.com/wido @bvbharathttps://github.com/bvbharat


You can view, comment on, or merge this pull request online at:

#1612

Commit Summary

  • packaging: Marvin and integration-tests packages

File Changes

  • A debian/cloudstack-integration-tests.installhttps://github.com//pull/1612/files#diff-0 (18)
  • A debian/cloudstack-marvin.installhttps://github.com//pull/1612/files#diff-1 (18)
  • A debian/cloudstack-marvin.postinsthttps://github.com//pull/1612/files#diff-2 (22)
  • M debian/controlhttps://github.com//pull/1612/files#diff-3 (10)
  • M debian/ruleshttps://github.com//pull/1612/files#diff-4 (8)
  • M packaging/centos63/cloud.spechttps://github.com//pull/1612/files#diff-5 (35)
  • M packaging/centos7/cloud.spechttps://github.com//pull/1612/files#diff-6 (35)

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1612, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEll7DVR5Q2zsmQAwaeoUZjLMzwggN41ks5qXcAKgaJpZM4JQdsP.

@rhtyd rhtyd force-pushed the shapeblue:package-marvin-tests branch 3 times, most recently from f54edd0 to d7af352 Jul 20, 2016
@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2016

@PaulAngus sorry I did not get the question. Put what repo in that org?

Based on the response received on the dev-ML thread on splitting marvin, this PR implements the alternative to package marvin and tests as separately install-able deb/rpm packages.

@rhtyd rhtyd force-pushed the shapeblue:package-marvin-tests branch 6 times, most recently from e1bdf9c to de041df Jul 20, 2016
@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2016

@rohit

This comment has been minimized.

Copy link

commented Jul 20, 2016

Guys I'm not the Rohit you'll are looking for so please stop @ mentioning me. 😄

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2016

@rohit if that keeps bothering you, I don't mind switching gh handle with you :)

@PaulAngus

This comment has been minimized.

Copy link
Member

commented Jul 20, 2016

Sorry yes – just wondering – rather than have to move it later as well…

Kind regards,

Paul Angus

VP Technology
paul.angus@shapeblue.com
www.shapeblue.com

From: Rohit Yadav [mailto:notifications@github.com]
Sent: 20 July 2016 09:22
To: apache/cloudstack cloudstack@noreply.github.com
Cc: Paul Angus paul.angus@shapeblue.com; Mention mention@noreply.github.com
Subject: Re: [apache/cloudstack] packaging: Marvin and integration-tests packages (#1612)

@PaulAngushttps://github.com/PaulAngus sorry I did not get the question. Put what repo in that org?

Based on the response received on the dev-ML thread on splitting marvin, this PR implements the alternative to package marvin and tests as separately install-able deb/rpm packages.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/1612#issuecomment-233880931, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEll7MKmlPcMAc28Yf9HcW-uocAOM2wiks5qXdqLgaJpZM4JQdsP.

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Jul 27, 2016

@swill @wido @PaulAngus @jburwell review and lgtm please, thanks :)

@wido

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

LGTM with the question why the Juniper fix is not a separate PR?

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

@wido thanks, the Juniper fix is not a separate PR as without that fix packaging/build failure were happening (some times, and every time on a centos7 machine).

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2016

Pinging for review -- @karuturi @koushik-das @abhinandanprateek @jburwell
If we can get this merged soon, all new PRs etc can be tested easily with CI systems as we'll get the marvin and integration-tests deb/rpms packages to test against built repos

@blueorangutan

This comment has been minimized.

Copy link

commented Aug 4, 2016

Packages built and available at: http://packages.shapeblue.com/cloudstack/custom/github-1612. Initiating automated testing with Trillian shortly.

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2016

@karuturi can we also test/merge this. This is a packaging change that only introduces 'cloudstack-marvin' and 'cloudstack-integration-tests' packages. The above package build verifies that it does not break packaging.

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 4, 2016

@rhtyd will test this tomorrow and commit

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 4, 2016

Can you please create a JIRA ticket for this?

rhtyd added 2 commits Aug 4, 2016
Increases allowed max and permgen memory flags to maven-surefire plugins.
This fixes unit test failures in cloud-server.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit fd7273b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

- maven: add explicit juniper-contrail-api maven repository
- marvin: build source distribution for both install and package mvn phases

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rhtyd rhtyd force-pushed the shapeblue:package-marvin-tests branch from e5750b3 to 0d0ad8f Aug 5, 2016
@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2016

@karuturi done.

@rhtyd rhtyd changed the title packaging: Marvin and integration-tests packages CLOUDSTACK-9446: Marvin and integration-tests packages Aug 5, 2016
@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

I just realised that I started bulding centos7 pacakges on 4.7 which is not supported now. Do you want this in 4.7 given that we dont do anymore releases on it?

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2016

@karuturi I don't understand your comment, centos7 packages have been supported since 4.6 (actually 4.5 too ships a centos7 repository). The PR is for 4.7 as it would fix and improve testing for all branches/versions since 4.7 (we at least need this on 4.8, 4.9 and master). Further, this does not make any changes to CloudStack.

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

I can see the following packages after a successful build on 4.7
cloudstack-agent-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-baremetal-agent-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-cli-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-common-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-integration-tests-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-management-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-marvin-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-usage-4.7.2-SNAPSHOT.el7.centos.x86_64.rpm

I am rebuilding it on 4.8

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

I meant 4.7 is not a supported release by the community and there wont be any more releases from it.

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2016

@karuturi thanks, I understand now. You're right, I sent for 4.7 as we support fwd-merging since 4.7 and we might need to test a 4.7 based security release in future.

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

I see the following successfully built packages on 4.8

cloudstack-agent-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-baremetal-agent-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-cli-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-common-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-integration-tests-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-management-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-marvin-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm
cloudstack-usage-4.8.1-SNAPSHOT.el7.centos.x86_64.rpm

I am forwarding merging this from 4.7 without further tests on 4.9 and master

asfgit pushed a commit that referenced this pull request Aug 5, 2016
packaging: Marvin and integration-tests packagesThis introduces two new cloudstack packages: marvin and integration-tests.
The two packages will make it easier for CI systems to install Marvin for a
specific cloudstack release/build and run integration tests that are specific
for that version/build.

Since Marvin may have its own dependencies, we're bundling the Marvin source tarball and installing it with pip in the post-installation script/phase.

This also fixed a build issue with using juniper-api maven repo.

/cc @swill @PaulAngus @jburwell @wido @bvbharat

* pr/1612:
  server: give more memory to tests
  packaging: Marvin and integration-tests packages

Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2016

Thank you @karuturi

@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

This is merged to all the branches 2875af7

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2016

Thanks @karuturi
I'm not sure why the PR did not close, closing it manually now.

@rhtyd rhtyd closed this Aug 5, 2016
@karuturi

This comment has been minimized.

Copy link
Member

commented Aug 5, 2016

@rhtyd I couldn't find either. Let me know if you see any issues.

@rhtyd

This comment has been minimized.

Copy link
Member Author

commented Aug 10, 2016

Just to note here for future reference: this PR was backported to 4.5 and 4.6 branches as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.