Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.11] CLOUDSTACK-9813: Extending Config Drive support #2097

Merged
merged 9 commits into from Jan 12, 2018

Conversation

@fmaximus
Copy link
Contributor

commented May 11, 2017

  • Added support for VMware
  • Build configdrive.iso on ssvm
  • Added support for VPC and Isolated Networks
  • Moved implementation to new Service Provider
  • UI fix: add support for urlencoded userdata
  • Add support for building systemvm behind a proxy

Co-Authored-By: Raf Smeets raf.smeets@nuagenetworks.net
Co-Authored-By: Frank Maximus frank.maximus@nuagenetworks.net
Co-Authored-By: Sigert Goeminne sigert.goeminne@nuagenetworks.net

@krissterckx

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@kiwiflyer the commit has been fixed, can the Work-in-progress be removed now?

@kiwiflyer kiwiflyer added this to the 4.11 milestone May 12, 2017
@kiwiflyer

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@krissterckx done.

@fmaximus fmaximus changed the title [4.11/Future] CLOUDSTACK-9813: Extending Config Drive support [4.11] CLOUDSTACK-9813: Extending Config Drive support May 12, 2017
sgoeminn pushed a commit to sgoeminn/ignition that referenced this pull request Jul 7, 2017
@sgoeminn sgoeminn force-pushed the nuagenetworks:feature/config_drive branch from 8ead399 to 4575540 Jul 7, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 4575540 to 9f51464 Jul 17, 2017
@cloudmonger

This comment has been minimized.

Copy link

commented Jul 17, 2017

ACS CI BVT Run

Sumarry:
Build Number 978
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=7
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_deploy_vm_iso.py

  • test_deploy_vm_from_iso Failing since 36 runs

  • test_volumes.py

  • test_06_download_detached_volume Failed

  • test_vm_life_cycle.py

  • test_10_attachAndDetach_iso Failing since 36 runs

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 69 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 69 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 68 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 68 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

@wido

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2017

There are merge conflicts with this PR. Would be great to get it in, could you take a look at them?

@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 9f51464 to 4c420c2 Aug 16, 2017
sgoeminn pushed a commit to sgoeminn/ignition that referenced this pull request Aug 31, 2017
sgoeminn pushed a commit to sgoeminn/ignition that referenced this pull request Sep 4, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 4c420c2 to 2bd51b7 Sep 29, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 2bd51b7 to c9631b4 Oct 26, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch 2 times, most recently from caa5b66 to 586fd15 Nov 2, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 586fd15 to 470fb4c Nov 23, 2017
@sgoeminn sgoeminn force-pushed the nuagenetworks:feature/config_drive branch from 470fb4c to 99a04da Dec 7, 2017
@rhtyd rhtyd removed this from the 4.11 milestone Dec 19, 2017
@fmaximus fmaximus force-pushed the nuagenetworks:feature/config_drive branch from 99a04da to 7685015 Dec 19, 2017
@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@fmaximus please fix the conflicts

@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 10, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 10, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1641

@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@blueorangutan test centos7 vmware-55u3

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 10, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

@krissterckx

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2018

@rhtyd can the 'requested changes' ask be removed ? This PR should be ready for merge.

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 11, 2018

Trillian test result (tid-2110)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31238 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2110-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_create_volume Failure 176.91 test_volumes.py
@krissterckx

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2018

@DaanHoogland @wido can you pls (re)approve this PR if you are OK with it ? Thanks

@wido

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2018

I will take a last look at this later today and LGTM if OK!

@wido
wido approved these changes Jan 11, 2018
@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 11, 2018

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 11, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 11, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1645

@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 11, 2018

@blueorangutan test matrix

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 11, 2018

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@DaanHoogland

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2018

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 11, 2018

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 12, 2018

Trillian test result (tid-2113)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 32067 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2113-xenserver-65sp1.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_edit_template Failure 90.10 test_templates.py
test_07_resize_fail Failure 32.26 test_volumes.py
@blueorangutan

This comment has been minimized.

Copy link

commented Jan 12, 2018

Trillian test result (tid-2114)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33858 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2114-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_vm_wrong_checksum Error 25.26 test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown Error 39.86 test_templates.py
test_07_resize_fail Failure 5.40 test_volumes.py
test_hostha_kvm_host_recovering Error 6.45 test_hostha_kvm.py
@blueorangutan

This comment has been minimized.

Copy link

commented Jan 12, 2018

Trillian test result (tid-2115)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37398 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2097-t2115-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_create_volume Failure 210.03 test_volumes.py
@rhtyd
rhtyd approved these changes Jan 12, 2018
@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

Tests LGTM, same failures as seen in baseline master branch #2376. I've my objections on adding test data to the test_data.py (polluting marvin library) instead of keeping test data and test together, however that is not a blocker to PR acceptance. @fmaximus @krissterckx please send a separate PR (maybe in future) to fix them.

@DaanHoogland

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2018

LGTM

@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

I'll honour reviews from @wido and @DaanHoogland , and based on no new regressions from test results merge the PR. I hope to get your support in further stabilizing master - @fmaximus @krissterckx @wido @DaanHoogland and others. Thanks.

@rhtyd rhtyd merged commit b176648 into apache:master Jan 12, 2018
2 checks passed
2 checks passed
Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.