Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template: create/updateTemplate should allow to set/change sshKeyEnabled #2922

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@shwstppr
Copy link
Contributor

commented Oct 23, 2018

Added sshKeyEnabled key in createTemplate and updateTemplate API.
Fixes #2822

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
Abhishek Kumar
template: create/updateTemplate should allow to set/change sshKeyEnabled
Added sshKeyEnabled key in createTemplate and updateTemplate API.
Fixes #2822.

Signed-off-by: Abhishek Kumar <abhishek.mrt@gmail.com>
@rhtyd

rhtyd approved these changes Oct 23, 2018

@rhtyd

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

commented Oct 23, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

This comment has been minimized.

Copy link

commented Oct 23, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2371

@rhtyd

This comment has been minimized.

Copy link
Member

commented Oct 23, 2018

@blueorangutan

This comment has been minimized.

Copy link

commented Oct 23, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

This comment has been minimized.

Copy link

commented Oct 24, 2018

Trillian test result (tid-3111)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2922-t3111-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 67 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_nic_secondaryip_add_remove Error 22.50 test_multipleips_per_nic.py
test_04_rvpc_network_garbage_collector_nics Failure 453.83 test_vpc_redundant.py

@rhtyd rhtyd merged commit c8ca9e2 into apache:master Oct 24, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rhtyd rhtyd added this to the 4.12.0.0 milestone Oct 24, 2018

@rhtyd rhtyd added the component:api label Oct 24, 2018

@rhtyd

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

@blueorangutan

This comment has been minimized.

Copy link

commented Jan 3, 2019

@rhtyd I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'dhlaluku', 'anuragaw', 'shwstppr']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.