Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null pointer exception when using ConfigKey.Scope.ManagementServer #3062

Merged

Conversation

GabrielBrascher
Copy link
Member

@GabrielBrascher GabrielBrascher commented Nov 27, 2018

Description

A null pointer is thrown if a ConfigKey.Scope.ManagementServer is used for configuring a ConfigKey.

The null pointer happens because the map _scopeLevelConfigsMap does not contain the ConfigKey.Scope.ManagementServer as a key.

Fixed by adding ConfigKey.Scope.ManagementServer in the map _scopeLevelConfigsMap.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@rafaelweingartner
Copy link
Member

rafaelweingartner commented Nov 27, 2018

@GabrielBrascher can you check?

ERROR] /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java:88: Line has trailing spaces. [RegexpSingleline]

@GabrielBrascher GabrielBrascher force-pushed the fix-management-server-scope-nullpointer branch from 03b1288 to e6149f6 Compare November 27, 2018 16:29
@GabrielBrascher GabrielBrascher removed this from To do in Master (4.12.0.0) Nov 27, 2018
@GabrielBrascher GabrielBrascher added this to the 4.12.0.0 milestone Nov 27, 2018
@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2466

@rohityadavcloud
Copy link
Member

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3224)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34070 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3062-t3224-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 68 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_nic_secondaryip_add_remove Error 47.23 test_multipleips_per_nic.py
test_04_rvpc_network_garbage_collector_nics Failure 520.93 test_vpc_redundant.py

@rohityadavcloud rohityadavcloud merged commit 5d7b33a into apache:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants