Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIP Nuage Cloudstack Plugin #3146

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@fmaximus
Copy link
Contributor

fmaximus commented Jan 25, 2019

Description

Removing the Nuage plugin as Nuage is discontinuing CloudStack support.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

  • Manual UI check
  • Smoke tests on Simulator
  • Upgrade from 4.11 after removing Nuage physical network

@fmaximus fmaximus added this to the 4.12.0.0 milestone Jan 25, 2019

@GabrielBrascher

This comment has been minimized.

Copy link
Member

GabrielBrascher commented Jan 25, 2019

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Jan 25, 2019

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@rhtyd

rhtyd approved these changes Jan 25, 2019

Copy link
Member

rhtyd left a comment

LGTM, thank you @fmaximus @krissterckx @smeetsr for your contributions and community participation, and for your time and effort on this PR to do a proper cleanup. It's unfortunate to read the email on dev list but I understand. It was a pleasure to work with you all and appreciate the quality of code and tests you had contributed and professionalism you've all shown. Thank you and good luck.

@@ -25,3 +25,7 @@ DROP TABLE IF EXISTS `cloud`.`iam_group_policy_map`;
DROP TABLE IF EXISTS `cloud`.`iam_group`;
DROP TABLE IF EXISTS `cloud`.`iam_policy_permission`;
DROP TABLE IF EXISTS `cloud`.`iam_policy`;

-- Cleanup Nuage VSP
DELETE FROM `cloud`.`host` WHERE id in (SELECT vsp.host_id FROM `cloud`.`external_nuage_vsp_devices` vsp);

This comment has been minimized.

Copy link
@rhtyd

rhtyd Jan 25, 2019

Member

@fmaximus please also remove issueNuageVspResourceRequest from role_permissions?

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Jan 25, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2568

@rafaelweingartner rafaelweingartner modified the milestones: 4.12.0.0, 5.0.0.0 Jan 25, 2019

@rafaelweingartner

This comment has been minimized.

Copy link
Member

rafaelweingartner commented Jan 25, 2019

Moved to 5.0.0. This PR is removing public APIs/features

@rhtyd

This comment has been minimized.

Copy link
Member

rhtyd commented Jan 25, 2019

@rafaelweingartner -1, deprecating or removing vendor/plugin specific non-core feature(s) and API(s) does not constitute a breaking of compatibility, warranting moving to 5.x. I'm +1 on removing the feature from master so if not 4.12.x, perhaps in 4.13.x, I'm sure we can put something in the docs around removal of features. Among the cloudstack plugins, the network and storage plugins are highly vendor dependent (and that said they may be developed/shipped outside of upstream project) and I think it should be up to Nuage how they want to support their users with cloudstack wrt a migration path.

@rafaelweingartner

This comment has been minimized.

Copy link
Member

rafaelweingartner commented Jan 25, 2019

I know you hate the number 5 ;), but do not worry, we will have a lot of time to debate over this in the near future...

Right now, 4.12 is being released, and master is freezed.

@svenvogel

This comment has been minimized.

Copy link
Contributor

svenvogel commented Jan 26, 2019

@fmaximus i heared it from sales men from nuage/nokia that they want to focus on sd wan. its very bad decision i think but management think in a other way. good luck and thanks for help in the last years!

Show resolved Hide resolved ui/scripts/configuration.js Outdated

@fmaximus fmaximus force-pushed the nuagenetworks:feature/remove_nuage branch from 181657d to 5a4efd9 Jan 28, 2019

@borisstoyanov

This comment has been minimized.

Copy link
Contributor

borisstoyanov commented Feb 11, 2019

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Feb 11, 2019

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Feb 11, 2019

Trillian test result (tid-3400)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33878 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3146-t3400-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 65 look OK, 5 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestTemplateHierarchy>:setup Error 1520.08 test_accounts.py
test_04_extract_Iso Failure 1.08 test_iso.py
test_03_vpc_privategw_restart_vpc_cleanup Failure 150.25 test_privategw_acl.py
test_04_extract_template Failure 1.09 test_templates.py
test_06_download_detached_volume Failure 11.45 test_volumes.py
@borisstoyanov
Copy link
Contributor

borisstoyanov left a comment

LGTM, except from the merge conflicts

@fmaximus fmaximus force-pushed the nuagenetworks:feature/remove_nuage branch from 5a4efd9 to d4d27ab Feb 12, 2019

@fmaximus

This comment has been minimized.

Copy link
Contributor Author

fmaximus commented Feb 12, 2019

Rebased to deal with conflicts caused by merge of #3112

@fmaximus fmaximus self-assigned this Feb 14, 2019

@rhtyd

rhtyd approved these changes Mar 26, 2019

@rhtyd

This comment has been minimized.

Copy link
Member

rhtyd commented Mar 26, 2019

@fmaximus master is unfrozen now, sorry but can you fix the conflicts again. We can merge this after running a final regression test. Thanks.

@fmaximus fmaximus force-pushed the nuagenetworks:feature/remove_nuage branch from d4d27ab to 0c9e699 Apr 3, 2019

@fmaximus

This comment has been minimized.

Copy link
Contributor Author

fmaximus commented Apr 3, 2019

I've solved the conflict.

@rhtyd

This comment has been minimized.

Copy link
Member

rhtyd commented Apr 14, 2019

Thanks @fmaximus - is this PR ready for testing/merging, the label WIP is not removed yet

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 14, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 14, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2698

@rhtyd

This comment has been minimized.

Copy link
Member

rhtyd commented Apr 14, 2019

@blueorangutan test matrix

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 14, 2019

@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 15, 2019

Trillian test result (tid-3492)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30178 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3146-t3492-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_scale_vm Failure 17.47 test_scale_vm.py
@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 15, 2019

Trillian test result (tid-3493)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33163 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3146-t3493-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 410.93 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 437.21 test_vpc_redundant.py
@blueorangutan

This comment has been minimized.

Copy link

blueorangutan commented Apr 15, 2019

Trillian test result (tid-3494)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34081 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3146-t3494-vmware-65.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.