Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplemented as a local exception #3170

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@DaanHoogland
Copy link
Contributor

commented Feb 8, 2019

Description

NotImplementedException from sun.reflect.generics.reflectiveObjects is not standard/guarateed by the jvm so a custom implementation is in order.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
@blueorangutan

This comment has been minimized.

Copy link

commented Feb 11, 2019

Trillian test result (tid-3399)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3170-t3399-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 66 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestTemplateHierarchy>:setup Error 1524.57 test_accounts.py
test_04_extract_Iso Failure 1.15 test_iso.py
test_04_extract_template Failure 1.09 test_templates.py
test_06_download_detached_volume Failure 11.53 test_volumes.py
@borisstoyanov
Copy link
Contributor

left a comment

LGTM, the marvin failures seems to be caused by the valid ssl connection and java download manager rejecting them. #3172

@rhtyd

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Let's use org.apache.commons.lang.NotImplementedException which is already used by some storage component?

@nvazquez
Copy link
Contributor

left a comment

LGTM

@rhtyd

rhtyd approved these changes Feb 12, 2019

@nathanejohnson

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

LGTM

@apache apache deleted a comment from blueorangutan Mar 8, 2019

@apache apache deleted a comment from borisstoyanov Mar 8, 2019

@apache apache deleted a comment from blueorangutan Mar 8, 2019

@apache apache deleted a comment from blueorangutan Mar 8, 2019

@apache apache deleted a comment from blueorangutan Mar 8, 2019

@apache apache deleted a comment from blueorangutan Mar 8, 2019

@DaanHoogland DaanHoogland force-pushed the DaanHoogland:notImplementedQimg branch from 84ec1b0 to 5a8aa83 Mar 8, 2019

@DaanHoogland

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

@blueorangutan package

@blueorangutan

This comment has been minimized.

Copy link

commented Mar 8, 2019

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

This comment has been minimized.

Copy link

commented Mar 8, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2621

@dhlaluku
Copy link
Contributor

left a comment

+1

@DaanHoogland

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@blueorangutan

This comment has been minimized.

Copy link

commented Mar 13, 2019

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

This comment has been minimized.

Copy link

commented Mar 13, 2019

Trillian test result (tid-3420)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 15676 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3170-t3420-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 65 look OK, 5 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestCreateVolume>:setup Error 0.00 test_volumes.py
ContextSuite context=TestVolumes>:setup Error 0.00 test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 7.71 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Error 7.72 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 7.73 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 6.70 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 5.66 test_vpc_redundant.py
test_01_VPC_nics_after_destroy Error 5.66 test_vpc_router_nics.py
test_02_VPC_default_routes Error 4.66 test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn Failure 7.31 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Failure 5.27 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Failure 3.15 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 5.26 test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs Error 3.24 test_host_maintenance.py

@rhtyd rhtyd added this to the 4.13.0.0 milestone Mar 25, 2019

@rhtyd rhtyd merged commit f88de7b into apache:master Mar 25, 2019

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gmueller-ewerk added a commit to gmueller-ewerk/cloudstack that referenced this pull request Mar 25, 2019

kvm: NotImplemented, with message to signify what is not implemented,…
… using commons-lang version (apache#3170)

NotImplementedException from sun.reflect.generics.reflectiveObjects is not standard/guarateed by the jvm so a custom implementation is in order.

pbankonier added a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019

kvm: NotImplemented, with message to signify what is not implemented,…
… using commons-lang version (apache#3170)

NotImplementedException from sun.reflect.generics.reflectiveObjects is not standard/guarateed by the jvm so a custom implementation is in order.

mweber92 added a commit to mweber92/cloudstack that referenced this pull request Apr 25, 2019

kvm: NotImplemented, with message to signify what is not implemented,…
… using commons-lang version (apache#3170)

NotImplementedException from sun.reflect.generics.reflectiveObjects is not standard/guarateed by the jvm so a custom implementation is in order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.